Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/satisfaction ratings start #67

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Conversation

luandy64
Copy link
Contributor

@luandy64 luandy64 commented Sep 15, 2021

Description of change

This PR pulls the bookmark out of the state to pass to the API as the start date for a sync.

There's already logic in the tap to insert the config's start date into state if there is no value present. So this PR doesn't handle any default value logic

Manual QA steps

  • Ran the tap

Risks

Rollback steps

  • revert this branch

@luandy64 luandy64 merged commit c98db4e into master Sep 15, 2021
@luandy64 luandy64 deleted the fix/satisfaction-ratings-start branch September 15, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants