Tdl 14803 check api access in discovery mode #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//github.com/singer-io/tap-zendesk into TDL-14803-check-api-access-in-discovery-mode
…//github.com/singer-io/tap-zendesk into TDL-14803-check-api-access-in-discovery-mode
KrisPersonal
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Tdl 14803 check api access in discovery mode (#84) * API call to the each stream in discovery mode done * removed generated catalog file * resolved pylint errors * Resolved cyclic import pylint error * Improved unittest case civerage * Updated error message for 403 forbidden error * Updated error handling * resolved pylint error * Removed empty catalog * Removed unused catalog file. * Removed unused state file * Removed unused state file * Removed unused file * Updated error message and unittest case for 404 error * Updated check access method * Resolved pylint error * recolved unused argument error * resolved kwargs error * Updated unittest cases * Updated unittest cases * Removed global variable * Improved unittest case coverage * updated 404 error * resolved pylint error * Updated typo error. * Removed f strings * Updated error handling * resloved pylint error * resolved unittest case error * Added more comments and updated code * resolved pylint error * updated method name * Added timeout error code * Resolved pylint error * added coverage report to artifact * added pylint back * Added comment * resolved pylint errors * Enhanced the code * Reutilized args0 * Moved request_timeout parameter to common class * Added comment * Removed static time * removed warning message * resolved pylint error * resolved the comments Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> * Tdl 15454 remove buffer from tickets (#85) * removed the buffer systesm * removed the unnecessary methods * fixed pylint errors * resolved pylint errors * added comments in test file * Added coverage report * added comment * added logger for printingcount of child streams * updated unittest Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> * Tdl 14799 correctly print logger (#86) * TDL-14799 added an extra check to verify if the error has message in it or not * TDL-14799-removed-the-extra-whitespaces * TDL-14799 resolved the comments * added new test cases and removed unwanted changes * added a new line * resolved the comment Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> * removed the trailing whitespace which failed the build * added pytest in the setup.py * added coverage report * added comments to testcases * added comment in the streams.py Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com> Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> * Updated unittest case * Tdl 15582 check best practices (#87) * Initial commit for best practises * Updated all_fields test case * Removed commented code * added coverage report * removed f string all fields test case * Updated test cases * Updated test case * Updated start_date for ticket_forms * updated start_date Co-authored-by: prijendev <88327452+prijendev@users.noreply.github.com> Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com> Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-14803 Check API access in Discovery mode
Note - Added code of PR79 in this PR because it was require. So, first PR79 need to merge and once that PR merged changes will not be reflected here.
Manual QA steps
Risks
Rollback steps