Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tdl 14624 crest master #88

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Tdl 14624 crest master #88

merged 6 commits into from
Nov 11, 2021

Conversation

dbshah1212
Copy link
Contributor

prijendev and others added 6 commits November 10, 2021 11:55

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* API call to the each stream in discovery mode done

* removed generated catalog file

* resolved pylint errors

* Resolved cyclic import pylint error

* Improved unittest case civerage

* Updated error message for 403 forbidden error

* Updated error handling

* resolved pylint error

* Removed empty catalog

* Removed unused catalog file.

* Removed unused state file

* Removed unused state file

* Removed unused file

* Updated error message and unittest case for 404 error

* Updated check access method

* Resolved pylint error

* recolved unused argument error

* resolved kwargs error

* Updated unittest cases

* Updated unittest cases

* Removed global variable

* Improved unittest case coverage

* updated 404 error

* resolved pylint error

* Updated typo error.

* Removed f strings

* Updated error handling

* resloved pylint error

* resolved unittest case error

* Added more comments and updated code

* resolved pylint error

* updated method name

* Added timeout error code

* Resolved pylint error

* added coverage report to artifact

* added pylint back

* Added comment

* resolved pylint errors

* Enhanced the code

* Reutilized args0

* Moved request_timeout parameter to common class

* Added comment

* Removed static time

* removed warning message

* resolved pylint error

* resolved the comments

Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* removed the buffer systesm

* removed the unnecessary methods

* fixed pylint errors

* resolved pylint errors

* added comments in test file

* Added coverage report

* added comment

* added logger for printingcount of child streams

* updated unittest

Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* TDL-14799 added an extra check to verify if the error has message in it or not

* TDL-14799-removed-the-extra-whitespaces

* TDL-14799 resolved the comments

* added new test cases and removed unwanted changes

* added a new line

* resolved the comment

Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com>

* removed the trailing whitespace which failed the build

* added pytest in the setup.py

* added coverage report

* added comments to testcases

* added comment in the streams.py

Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com>
Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com>
Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Initial commit for best practises

* Updated all_fields test case

* Removed commented code

* added coverage report

* removed f string all fields test case

* Updated test cases

* Updated test case

* Updated start_date for ticket_forms

* updated start_date
@KrisPersonal KrisPersonal merged commit c410f3e into master Nov 11, 2021
@KrisPersonal KrisPersonal deleted the TDL-14624-crest-master branch November 11, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants