Add/wrapper scripts

[marcodelapierre]

Edits to use a dynamically defined moduleDir variable in all templates, rather than fixed {{ module_dir }}:

• wrapper templates: location of env-file
• modulefile templates
  • defining a local moduleDir variable
  • used for wrappers PATH, location of env-file, help output
  • both LUA and TCL
• no more need to pass module_dir when rendering modulefile templates

Fix in wrapper base script:

• for CSH shell, variables always need to be defined with set
• note that export is not needed for bash shell, as the variable is only used directly in the wrapper script, not in any sub process
  • if willing to revert, then for consistency the CSH case needs setenv (can't recall the exact syntax)

[vsoch]

Just a few small questions - and is there a way to test both of these?

[vsoch]

What is myFileName is that a function you are writing?

[vsoch]

How does this work?

[marcodelapierre]

No worries, so this is the very same syntax I had envisaged a couple of weeks ago for the dynamic moduleDir paths, and that we had discussed for use to define the PATH variable by the modulefiles.
The change is that here I am using it to define a Lua/Tcl variable, that can be re-used across the modulefile.

myFileName has the full path of the modulefile, and is documented in the Lmod docs: https://lmod.readthedocs.io/en/latest/050_lua_modulefiles.html
As for the match syntax, it is a generic Lua syntax, which I had found it across the internet (stack overflow or similar is the likely source).

I have tested it both in dummy Lua modulefiles, and by generating and testing production SHPC modulefiles.
Or do you mean tests to be implemented in the SHPC testing framework?

If it can help, I can lookup our old thread, and other links if relevant :)

[vsoch]

okay looking good! I think there are two more places that we missed changing module_dir:

• https://github.com/singularityhub/singularity-hpc/blob/add/wrapper-scripts/registry/vanessa/salad/docker_fork.sh
• https://github.com/singularityhub/singularity-hpc/blob/add/wrapper-scripts/registry/vanessa/salad/singularity_fork.sh

[marcodelapierre]

edits now done for module_dir in vanessa/salad/!