-
-
Notifications
You must be signed in to change notification settings - Fork 28
Add/wrapper scripts #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vsoch
merged 7 commits into
singularityhub:add/wrapper-scripts
from
marcodelapierre:add/wrapper-scripts
Mar 2, 2022
Merged
Add/wrapper scripts #499
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
31f0e1e
wrapper/templates/bases: csh always needs "set" for variables
marcodelapierre 0716309
wrappers/templates: using variable moduleDir
marcodelapierre a2a326d
modules/templates lua: moduleDir always replaces {{ module_dir }}
marcodelapierre 6f6bc11
modules/templates tcl: moduleDir always replaces {{ module_dir }}
marcodelapierre 1ca2b6f
main/container: no more need to pass module_dir to template.render fo…
marcodelapierre 11ac86d
registry/vanessa/salad: updated wrapper scripts with moduleDir var
marcodelapierre 3148d9c
registry/vanessa/salad: typo in singularity_fork.sh
marcodelapierre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is myFileName is that a function you are writing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, so this is the very same syntax I had envisaged a couple of weeks ago for the dynamic moduleDir paths, and that we had discussed for use to define the PATH variable by the modulefiles.
The change is that here I am using it to define a Lua/Tcl variable, that can be re-used across the modulefile.
myFileName has the full path of the modulefile, and is documented in the Lmod docs: https://lmod.readthedocs.io/en/latest/050_lua_modulefiles.html
As for the match syntax, it is a generic Lua syntax, which I had found it across the internet (stack overflow or similar is the likely source).
I have tested it both in dummy Lua modulefiles, and by generating and testing production SHPC modulefiles.
Or do you mean tests to be implemented in the SHPC testing framework?
If it can help, I can lookup our old thread, and other links if relevant :)