Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glimmer 2 DOMException for popover components #122

Closed
jordpo opened this issue Dec 7, 2016 · 4 comments
Closed

Glimmer 2 DOMException for popover components #122

jordpo opened this issue Dec 7, 2016 · 4 comments
Labels
bug

Comments

@jordpo
Copy link

jordpo commented Dec 7, 2016

With Ember 2.10, an exception is thrown if you are wrapping a popover component in an if block. It seems related to this issue:

yapplabs/ember-wormhole#66

We are getting around it by wrapping the popover- component in a div.
Glennvd added a commit to Glennvd/ember-tooltips that referenced this issue Jan 31, 2017
@Glennvd
Fix glimmer 2 exceptions
d908710 
Fix for sir-dunxalot#122 that also works for tooltip-on-element
@Glennvd Glennvd mentioned this issue Jan 31, 2017
Closed
@a15n
Copy link
Contributor

a15n commented Jan 31, 2017

LGTM

@sir-dunxalot do you approve?

@sir-dunxalot
Copy link
Owner

Was that meant to be a comment on #176? If so, yes.

@a15n
Copy link
Contributor

a15n commented Feb 1, 2017

haha yes it was

@kennydp kennydp mentioned this issue Sep 9, 2018
Merged
@maxfierke
Copy link
Collaborator

Addressed in 2.11.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maxfierke @jordpo @sir-dunxalot @a15n