Fix for glimmer 2 issue #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kennydp! Thanks for the PR. Could you add a test case for the bug that this is fixing? |
|
Sure thing. I'll try to add one when I find some time later this week |
looks great, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually builds upon this open PR : #176.
I just added what was suggested. If you are using the wrapper, the target is the grandparent element. If you are not using it, it will still be the same code as before. This should not break anything for people using the thether-tooltip-and-popover by itself.
This should fix the glimmer 2 exceptions people are having when using this addon (#122).