Cross compiling for Solaris-like OS #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not hugely in favour of adding a dependency to Logrus, being as it's a library included in a large amount of contexts. Will it really require vendoring very much code to get just this piece of functionality for Solaris derived OSes? |
|
Since an internal syscall package was frozen and there isn't SYS_IOCTL for Solaris, the package "gaoling.org/x/sys" seems to me is only way to get access to low-level function. If someone have a better idea I would be glad to hear it. Besides, extra dependency is actual only for Solaris platform and I suggest this pull-request because I need gorethink driver for RethinkDB working under Solaris. |
sirupsen
added a commit
that referenced
this pull request
Nov 17, 2015
Cross compiling for Solaris-like OS
|
Thanks for your patch :) |
devopstaku
pushed a commit
to devopstaku/logrus
that referenced
this pull request
Aug 9, 2016
Cross compiling for Solaris-like OS
0xE0F
pushed a commit
to 0xE0F/logrus
that referenced
this pull request
Feb 23, 2017
There are missing "io" import and unused variable Releated issues sirupsen#471 sirupsen#289
Paddy-Truck
pushed a commit
to Paddy-Truck/logrus
that referenced
this pull request
Sep 8, 2017
There are missing "io" import and unused variable Releated issues sirupsen#471 sirupsen#289
cgxxv
pushed a commit
to cgxxv/logrus
that referenced
this pull request
Mar 25, 2022
Cross compiling for Solaris-like OS
cgxxv
pushed a commit
to cgxxv/logrus
that referenced
this pull request
Mar 25, 2022
There are missing "io" import and unused variable Releated issues sirupsen#471 sirupsen#289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #112 not all OS could be built. I've added support for Solaris OS (illumos kernel and SmartOs as well).
Since golang doesn't define SYS_IOCTL for Solaris, I've found nice extension "golang.org/x/sys" which has built-in IoctlGetTermios function.
I've seen projects who solve issue with absence of SYS_IOCTL by adding it manually, but for me using golang.org/x/sys seem more portable way.