Fixed compilation for Solaris #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are missing "io" import and unused variable Releated issues sirupsen#471 sirupsen#289
|
Fixed in master, sorry. |
|
Yup, no worries, but unused variable still there: |
|
Ugh, sorry @0xE0F :( I don't have a solaris machine to run this on :( I'll fix in master. |
|
Released as v0.11.4 |
|
Cheers |
cgxxv
pushed a commit
to cgxxv/logrus
that referenced
this pull request
Mar 25, 2022
Fixed compilation for Solaris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #471 compilation on Solaris was broken. Here's a fix for it.
There are missing "io" import and unused variable
Releated issues #471 #289