-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: UIKitIntrospectionViewController doesn't handle state updates #194
Comments
Great point. Okay so the fix should be to call the customize callback in |
Co-authored-by: David Roman <2538074+davdroman@users.noreply.github.com>
@chwo this is now fixed in 0.2.1. Please update and let me know if it works for you. |
I'm afraid #192 didn't fix this for some reason. I'm currently investigating why. |
This actually fixes the regression in #194. My bad for not checking better. A good area of improvement for automated tests.
This is now actually fixed in 0.2.2, I tested it with one of my libraries which broke with 0.2.0. Closing for now but feel free to reopen if you experience this issue again. |
@davdroman I have tested it and it works again in 0.2.2. Thank you for the fast fix. 🙌 |
Description
UIKitIntrospectionViewController
was changed in version 0.2.0 Fix view controller introspection #165customize
handler was called in theupdateUIViewController
so it was called on state changescustomize
handler is only called inmakeUIViewController
so it is only called with the initial state and isn't called on state changesUse case
We use
introspectSearchController
to introspect a SwiftUI List with thesearchable
modifier and want to configure properties of the searchController based on the state (if the list is empty or not). So thecustomize
handler needs to be called again if the state (the list entries) changes.The text was updated successfully, but these errors were encountered: