-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix view controller introspection #165
Fix view controller introspection #165
Conversation
…apply customization using its IntrospectionUIView's moveToWindowHandler.
Are there any notable changes in behavior with this approach? Is the callback invoked slightly earlier (in terms of run loops) than it would if it was added on |
Hi David, I haven't noticed any changes in behavior except that I am now able to consistently find views and view controllers. |
I had a similar issue with my NavigationController callbacks not being called when navigating to my Views while a fullscreen cover was being dismissed. It felt too hacky to play with artificial delays... Switching to @rzulkoski fixed all my issues and my callbacks are now called propery. |
I can confirm this branch fixes a show-stopping bug in my project where a |
Looks pretty good, thanks! Wondering why the GitHub workflow isn't running.. |
I think any tests related to |
I've been granted maintainer access to this repo so I'm going to do my very best to get this merged ASAP. Right now, this PR is blocked by the issues reported in #179 so I'll try and take care of that first. |
UIKitIntrospectionViewController
to also use its view's moveToWindowHandler when applying customizations.UIKitIntrospectionView
andUIKitIntrospectionViewController
to set their handlers up front in their respectivemakeUIView(Controller)
methods rather than delaying it untilupdateUIView(Controller)
is called.