Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view controller introspection #165

Merged

Conversation

rzulkoski
Copy link
Contributor

@rzulkoski rzulkoski commented Sep 23, 2022

  • Updated UIKitIntrospectionViewController to also use its view's moveToWindowHandler when applying customizations.
  • Updated both UIKitIntrospectionView and UIKitIntrospectionViewController to set their handlers up front in their respective makeUIView(Controller) methods rather than delaying it until updateUIView(Controller) is called.

…apply customization using its IntrospectionUIView's moveToWindowHandler.
@davdroman
Copy link
Collaborator

davdroman commented Dec 14, 2022

Are there any notable changes in behavior with this approach? Is the callback invoked slightly earlier (in terms of run loops) than it would if it was added on updateUIView?

@rzulkoski
Copy link
Contributor Author

Hi David, I haven't noticed any changes in behavior except that I am now able to consistently find views and view controllers.

@nashfive
Copy link

I had a similar issue with my NavigationController callbacks not being called when navigating to my Views while a fullscreen cover was being dismissed. It felt too hacky to play with artificial delays... Switching to @rzulkoski fixed all my issues and my callbacks are now called propery.
When can these changes be incorporated ?

@danhalliday
Copy link

I can confirm this branch fixes a show-stopping bug in my project where a NavigationView was only being picked up about half the time.

@davdroman davdroman mentioned this pull request Jan 24, 2023
@SplittyDev
Copy link
Collaborator

Looks pretty good, thanks! Wondering why the GitHub workflow isn't running..

@rzulkoski
Copy link
Contributor Author

I think any tests related to List will fail due to iOS 16 switching to UICollectionView instead of UITableView.

@davdroman
Copy link
Collaborator

I've been granted maintainer access to this repo so I'm going to do my very best to get this merged ASAP. Right now, this PR is blocked by the issues reported in #179 so I'll try and take care of that first.

@davdroman davdroman added the blocked This issue is blocked by something else. label Feb 3, 2023
@davdroman davdroman removed the blocked This issue is blocked by something else. label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants