Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faux Italic Issue with Playfair Display on Seafoam Theme in iPhone Safari #2188

Closed
Tracked by #1142
Typogram opened this issue Oct 24, 2023 · 6 comments
Closed
Tracked by #1142
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@Typogram
Copy link

Typogram commented Oct 24, 2023

Current Behavior

There seems to be a typography issue with the heading font in the Seafoam Theme. The Playfair Display Italic is registered as a normal style, causing the font to undergo a 'faux italic' transformation by the browser's algorithm, which results in an undesired appearance.

Screenshots:
Faux italic (iPhone safari)
image

Correct rendering (Windows chrome)
image

Expected Behavior

The italic style of the Playfair Display font should be displayed as intended without any additional skewing or faux italic transformation applied.

Actual behavior:
The font is skewed further by the browser’s algorithm, creating a faux italic effect, which affects the typography aesthetics.

Steps To Reproduce

  1. Open iPhone Safari
  2. Navigate to the page with the Seafoam Theme applied
  3. Observe the heading font (Playfair Display Italic)

Link to Reproduction / Stackblitz

No response

More Information

Environment:

  • Device: iPhone
  • Browser: Safari
@Typogram Typogram added the bug Something isn't working label Oct 24, 2023
@Typogram
Copy link
Author

Problem code:

@font-face {
    font-family: Playfair Display;
    src: url(../../../fonts/PlayfairDisplay-Italic.ttf);
    font-display: swap
}

Needs to be

@font-face {
    font-family: Playfair Display;
    src: url(../../../fonts/PlayfairDisplay-Italic.ttf);
    font-display: swap;
    font-style: italic;
}

@Typogram
Copy link
Author

The cli tool also generate site with this issue if the options to install the seafoam theme is chosen.

@Typogram
Copy link
Author

Typogram commented Oct 24, 2023

Similarly, there are also faux bold problem with modern, gold-nouveau and rocket themes in the heading font. Need to register fonts with proper font-weight in the @font-face.

@endigo9740
Copy link
Contributor

endigo9740 commented Oct 24, 2023

Thanks for bringing this up and providing a solution @Typogram. If you get a chance we would gladly welcome a PR for this. The styles for the documentation site are handled here:
https://github.com/skeletonlabs/skeleton/blob/dev/sites/skeleton.dev/src/app.postcss

Per the CLI, that's handled by @niktek and/or @Mahmoud-zino. I'd suggest creating a second thread that links to this issue here:
https://github.com/skeletonlabs/create-skeleton-app/issues

@endigo9740
Copy link
Contributor

We never quite got a fix on this issue, so I'm opening it back up for anyone to jump on an address. Thanks!

@endigo9740 endigo9740 modified the milestones: v3.0 (Next), v2.0 Dec 19, 2023
@endigo9740 endigo9740 self-assigned this Dec 20, 2023
@endigo9740 endigo9740 modified the milestones: v2.0, v3.0 (Next) Dec 20, 2023
@endigo9740
Copy link
Contributor

In an effort to prepare for Skeleton v3, we're consolidate some related issues down to a single ticket. This will ensure that we can see the full context of requests when the time comes to refactor and update this feature going forward. If you wish to add additional feedback or suggestions, please so here:

@endigo9740 endigo9740 modified the milestones: v3.0 (Next), v2.0 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants