-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: Issue #2188 - Faux Italic and Faux Bold #2192
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Awesome, thanks @Typogram. I tend to do PR reviews on Friday, so expect an update then. With a quick glance though all looks well and I expect this will be merged right away. |
@endigo9740 I am impressed by how organized and planned you are maintaining the project. Learned a lot from you! |
Ha, I'm glad we give the illusion of organization. We do try, but sometimes it feels like we're just building the ship as we sail it. I appreciate the kind words all the same! |
@Typogram so checking this, I'm not quite seeing the expected result. I personally don't own an iPhone, so I'm opting for a simulator, which tends to be fairly close to the real device. On the left is the preview URL that includes your changes, on the right is the live production site. While visually changed (slightly bolder, a bit wider), it doesn't quite match the Windows version you posted. Does this match expectations? Desktop Safari has similar results, here's the production site: Versus the preview URL: Here's another copy of the Windows image you posted to compare: If this looks correct to you, then I'm happy to merge. I just wanted to confirm! |
The image doesn't look correct. Please don't merge. I will find a time to look into this further. Sorry about that. |
@Typogram all good, that's why I wanted to check. I think going forward I'll be doing PR audits on Saturday/Sunday, so you have some time. |
@Typogram just checking in on this. I'll set this back into the draft state for now, feel free to bump it up to "ready for review" when you reach that point. |
No response in a few weeks so I'm going to consider this abandoned. I would still appreciate a fix on this, so feel free to resubmit at any time. Thanks! |
Description:
Fixes: #2188
Summary of Changes:
This pull request addresses the issue related to the inappropriate rendering of faux italic and faux bold styles (#2188). The necessary adjustments have been made to ensure that the typography is displayed as intended without any unintended stylings.
Details:
Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm check
pnpm format
pnpm test