Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Issue #2188 - Faux Italic and Faux Bold #2192

Closed
wants to merge 1 commit into from

Conversation

Typogram
Copy link

Description:

Fixes: #2188

Summary of Changes:

This pull request addresses the issue related to the inappropriate rendering of faux italic and faux bold styles (#2188). The necessary adjustments have been made to ensure that the typography is displayed as intended without any unintended stylings.

Details:

  • Corrected the font styling issues preventing the proper display of italic and bold text.
  • Adjusted the relevant CSS rules and typography components to ensure accuracy in text representation.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

⚠️ No Changeset found

Latest commit: fedff11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Oct 26, 2023 4:18pm

@endigo9740
Copy link
Contributor

endigo9740 commented Oct 26, 2023

Awesome, thanks @Typogram. I tend to do PR reviews on Friday, so expect an update then. With a quick glance though all looks well and I expect this will be merged right away.

@Typogram
Copy link
Author

@endigo9740 I am impressed by how organized and planned you are maintaining the project. Learned a lot from you!

@endigo9740
Copy link
Contributor

Ha, I'm glad we give the illusion of organization. We do try, but sometimes it feels like we're just building the ship as we sail it. I appreciate the kind words all the same!

@endigo9740
Copy link
Contributor

endigo9740 commented Oct 27, 2023

@Typogram so checking this, I'm not quite seeing the expected result. I personally don't own an iPhone, so I'm opting for a simulator, which tends to be fairly close to the real device.

On the left is the preview URL that includes your changes, on the right is the live production site. While visually changed (slightly bolder, a bit wider), it doesn't quite match the Windows version you posted. Does this match expectations?

Screenshot 2023-10-27 at 10 11 09 AM

Desktop Safari has similar results, here's the production site:

Screenshot 2023-10-27 at 10 14 24 AM

Versus the preview URL:

Screenshot 2023-10-27 at 10 14 19 AM

Here's another copy of the Windows image you posted to compare:

image

If this looks correct to you, then I'm happy to merge. I just wanted to confirm!

@Typogram
Copy link
Author

The image doesn't look correct. Please don't merge. I will find a time to look into this further. Sorry about that.

@endigo9740
Copy link
Contributor

@Typogram all good, that's why I wanted to check. I think going forward I'll be doing PR audits on Saturday/Sunday, so you have some time.

@endigo9740
Copy link
Contributor

@Typogram just checking in on this. I'll set this back into the draft state for now, feel free to bump it up to "ready for review" when you reach that point.

@endigo9740 endigo9740 marked this pull request as draft November 5, 2023 16:23
@endigo9740
Copy link
Contributor

No response in a few weeks so I'm going to consider this abandoned. I would still appreciate a fix on this, so feel free to resubmit at any time. Thanks!

@endigo9740 endigo9740 closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faux Italic Issue with Playfair Display on Seafoam Theme in iPhone Safari
2 participants