Skip to content

Conversation

@endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Aug 28, 2023

Linked Issue

Closes #1915

Description

Instead of hardcoding a toc- prefix to all Table of Content hash links, we now recommend supplying a custom heading ID when a conflict arises. However, I've also implement a means to manually set your own prefix/suffix in case this is required.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@endigo9740 endigo9740 linked an issue Aug 28, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Aug 28, 2023 6:12pm

@endigo9740 endigo9740 changed the base branch from dev to v2 August 28, 2023 17:43
@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

🦋 Changeset detected

Latest commit: 9c98d16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AdrianGonz97 AdrianGonz97 merged commit 563fabd into v2 Aug 28, 2023
@AdrianGonz97 AdrianGonz97 deleted the chore/toc-head-id-adjustment branch August 28, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table of Contents "toc-" prefix is visible in the URL hash

2 participants