Skip to content

Conversation

@Mahmoud-zino
Copy link
Contributor

Linked Issue

Closes #1949
Closes #1944
Closes #1943

Description

  1. solved a bunch of events bugs in Tree-view
  2. Reworked the recursive tree view:
    • Recursive tree-view is now a separate component.
    • The data is controlled using arrays of id's (expandedNodes, disabledNodes, checkedNodes, indeterminateNodes)
    • the arrays are 2 way binded => changing the array will update the GUI and changing the GUI will update the Array

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2023

🦋 Changeset detected

Latest commit: decd2e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Sep 29, 2023 5:11pm

@endigo9740
Copy link
Contributor

endigo9740 commented Sep 29, 2023

@Mahmoud-zino This looks good to me, we're primarily going to be respond to the feedback we receive regarding this once it goes live.

That said, your changeset does not adequately reflect the work done. Remember these support markdown so I suggest a bullet list like so:

feat: Multiple revisions and updates to the Tree View feature:
- change 1
- change 2
- ...

Once that change is made I'm happy to merge.

@endigo9740 endigo9740 merged commit 2457bc9 into skeletonlabs:dev Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants