Skip to content

Conversation

@jdahlborg
Copy link

Description

Add support for displaying trail content in TreeViewItem component

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

…content in TreeViewDataDrivenItem component

feat(TreeViewItem.svelte): add support for displaying trail content in TreeViewItem component
docs(types.ts): add documentation for trail property in TreeViewNode interface
@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

⚠️ No Changeset found

Latest commit: 37f288e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Sep 28, 2023 2:53pm

@endigo9740
Copy link
Contributor

endigo9740 commented Sep 28, 2023

Hey @jdahlborg, we typically ask for prior discussion before non-trivial changes are implemented. Mainly to prevent overlap and redundancy. In this case, it would have been useful to alert you to the fact this feature is still actively in development:

I'm going to ping @Mahmoud-zino, the author of this feature, to do a review of this and determine how we should move forward. We may need to close out your PR and fold this into his, or we might need to revisit it after his pending PR is merged.

Mahmoud, you have my full support for whatever you decide.

@Mahmoud-zino
Copy link
Contributor

@jdahlborg @endigo9740
The added trail was requested previously and I don't have anything against it (it doesn't effect the functionality).
However we opted to a separate component for the recursive tree-view to make testing easier.

This means the TreeViewDataDrivenItem.svelte doesn't exist anymore and the changes should be made to the normal tree-view and RecursiveTreeView after merging this PR #2069

So I would say let's close this PR and wait until the rework PR is merged, after that you can create an issue and implement the change on the new component as well 👍

@endigo9740
Copy link
Contributor

endigo9740 commented Sep 28, 2023

@Mahmoud-zino that makes sense.

@jdahlborg I'd recommend following this instruction. If you have any follow ups feel free to tag us here, or we're typically available in the #contributors channel on Discord.

Thanks!

@endigo9740 endigo9740 closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants