merge #1
Merged
merge #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-roller completed checks. Merging.
Auto-roller completed checks. Merging.
Auto-roller completed checks. Merging.
The behavior of acquire+release annotation handling has changed in https://reviews.llvm.org/D49355 which breaks the build with the new Clang. However, as has been pointed out, the acquire+release isn't the right way to prevent double locking as the annotations negate each other; the correct way is to use excludes or negative requires. Using excludes annotations also requires using std::lock_guard instead of std::unique_lock because the latter doesn't have the thread annotations due to deferred locking which is not needed in Flutter and so std::lock_guard is a sufficient alternative.
Auto-roller completed checks. Merging.
Auto-roller completed checks. Merging.
Auto-roller completed checks. Merging.
This reverts commit bc885f3.
This reflects that we no longer uses travis. Scripts are moved to ci folder.
Auto-roller completed checks. Merging.
dart-lang/sdk@17b54c7 Improve error detection in search code dart-lang/sdk@0ac1178 Initial stress test for code completion dart-lang/sdk@e0f6fdf Refactor testing:TestConfiguration to use smith:Configuration by inclusion. dart-lang/sdk@95d1ebd Fix one cause of timeouts in tests dart-lang/sdk@72b2542 Mark tests with Dart 1 constants in const context failing in all configs. dart-lang/sdk@42b02e0 Add more test steps to the analyzer --use-cfe bots. dart-lang/sdk@8bec83b Add the analyzer-use-cfe-linux bot to the commit queue. dart-lang/sdk@315216e [dart2js] Avoid collision with getInterceptor. dart-lang/sdk@f02d4d4 Fix bad merge dart-lang/sdk@1a83245 Triage language tests for void dart-lang/sdk@35a982b [VM kernel] Add missing type parameter finalization in type reader. dart-lang/sdk@09a8660 fix typo dart-lang/sdk@8cbbd7a [VM interpreter] Use write barrier in implicit setter. dart-lang/sdk@91caf82 Do self-interceptor optimization on a per-use basis dart-lang/sdk@8df84c0 Store resolution for out of range integer literals. dart-lang/sdk@bfa890d [vm/compiler] Various 64-bit operator improvements. dart-lang/sdk@92a7094 Fix three missing return warnings. dart-lang/sdk@1babc13 [vm/kernel/bytecode] Report compile-time errors from constant evaluation while generating bytecode dart-lang/sdk@8114ecb Fix tests after fixing constant fields with CFE. dart-lang/sdk@85edb76 Fix field constants verifying with CFE. dart-lang/sdk@8692936 Verify constants using Analyzer. dart-lang/sdk@b83072c Clean up use of callFailingTest dart-lang/sdk@8d3d82a [vm/kernel] Untangle the spaghetti-code in BuildGraphOfFunction and fix bugs. dart-lang/sdk@368bcc4 Add parse dartdoc tests for fasta parser dart-lang/sdk@cda3659 [fasta] Handle annotations on formals of typedefs dart-lang/sdk@46743f3 Remove $runtime == drt sections and uses of drt from status files. dart-lang/sdk@637e55d [kernel] Add VariableDeclarations to represent formals of Typedefs dart-lang/sdk@4c455e7 [VM] During hot-reload check if .packages was modified, tell IKG to re-load it if so dart-lang/sdk@5a259ac De-flake the analysis server integration tests. dart-lang/sdk@380696f Set element/type for some resynthesized expressions. dart-lang/sdk@4ab8408 [vm/kernel/bytecode] Support partial tear-off instantiation constants in bytecode generator and bytecode reader dart-lang/sdk@62a2752 Translate ConstructorElement(s) of parameterized InterfaceType(s) to ConstructorMember(s). dart-lang/sdk@a19a468 Revise CHANGELOG. dart-lang/sdk@91c6130 CHANGELOG copyedits dart-lang/sdk@5f4c617 Fix typo in CHANGELOG.md dart-lang/sdk@5313553 Run the analysis server 'analysis-server-cold' with --use-cfe. dart-lang/sdk@758e5ea Use '=' for default values of named parameters. dart-lang/sdk@f625490 Attempt to fix failures on the windows bot dart-lang/sdk@bbfc465 Cleaned up a few entries in the CHANGELOG dart-lang/sdk@e402732 Improve documentation of the -O flag
Auto-roller completed checks. Merging.
Auto-roller completed checks. Merging.
Auto-roller completed checks. Merging.
Until https://chromium-review.googlesource.com/c/chromium/tools/build/+/1164636 landed, we'll use this to unblock the Chrome bot.
Auto-roller completed checks. Merging.
* Reland "Updated background execution implementation for Android" w/ JNI fixes for merge breakages This reverts commit 5442c0a.
* Updated DartCallbackCache to write callback cache to disk which is restored on engine startup * Ensure cache isn't moved off disk in iOS
This is needed to avoid jank when resizing an embedded Android view. See flutter/flutter#19572 (comment)
It turns out that Skia is much slower at drawing paint inside a clipped path than directly drawing that path. (Average frame time of 22ms vs 18ms in flutter_galary transition test.)
Auto-roller completed checks. Merging.
…#5968) This allows the framework to know that a frame with the resized view is ready and to behave deterministically to workaround the jank issue described in flutter/flutter/19572
Auto-roller completed checks. Merging.
- Switch core snapshot to Dart 2 and remove support for loading platform.dill. - Remove support for loading script snapshots. - Remove support for loading source. - Remove settings and fix names to reflect the above. - Remove support for loading the service isolate from source.
Auto-roller completed checks. Merging.
This updates the embedder API but introduces no breaking ABI/API changes.
Auto-roller completed checks. Merging.
Auto-roller completed checks. Merging.
Thanks, Chinmay
skia-flutter-autoroll
added a commit
that referenced
this pull request
Jan 23, 2020
https://dart.googlesource.com/sdk.git/+log/6aa7407d6309..e84bea25df23 git log 6aa7407..e84bea2 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 jensj@google.com [CFE] Fix crash in incremental compiler caused by async redirecting factory 2020-01-23 jensj@google.com [CFE] Incremental compiler refactor #1 2020-01-23 athom@google.com [release] Prepare CHANGELOG for 2.7.1 2020-01-23 sstrickl@google.com [vm] Refactor debug info handling code into a new package. 2020-01-23 jensj@google.com [CFE] Strong test can have linked dependencies 2020-01-23 johnniwinther@google.com [cfe] Check null nullable accesses and include null in inferred type for null aware expressions Created with: gclient setdep -r src/third_party/dart@e84bea25df23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: dart-vm-team@google.com
skia-flutter-autoroll
added a commit
that referenced
this pull request
Jan 23, 2020
https://dart.googlesource.com/sdk.git/+log/6aa7407d6309..e84bea25df23 git log 6aa7407..e84bea2 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 jensj@google.com [CFE] Fix crash in incremental compiler caused by async redirecting factory 2020-01-23 jensj@google.com [CFE] Incremental compiler refactor #1 2020-01-23 athom@google.com [release] Prepare CHANGELOG for 2.7.1 2020-01-23 sstrickl@google.com [vm] Refactor debug info handling code into a new package. 2020-01-23 jensj@google.com [CFE] Strong test can have linked dependencies 2020-01-23 johnniwinther@google.com [cfe] Check null nullable accesses and include null in inferred type for null aware expressions Created with: gclient setdep -r src/third_party/dart@e84bea25df23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: dart-vm-team@google.com
skia-flutter-autoroll
added a commit
that referenced
this pull request
Jan 23, 2020
https://dart.googlesource.com/sdk.git/+log/6aa7407d6309..e84bea25df23 git log 6aa7407..e84bea2 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 jensj@google.com [CFE] Fix crash in incremental compiler caused by async redirecting factory 2020-01-23 jensj@google.com [CFE] Incremental compiler refactor #1 2020-01-23 athom@google.com [release] Prepare CHANGELOG for 2.7.1 2020-01-23 sstrickl@google.com [vm] Refactor debug info handling code into a new package. 2020-01-23 jensj@google.com [CFE] Strong test can have linked dependencies 2020-01-23 johnniwinther@google.com [cfe] Check null nullable accesses and include null in inferred type for null aware expressions Created with: gclient setdep -r src/third_party/dart@e84bea25df23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: dart-vm-team@google.com
skia-flutter-autoroll
added a commit
that referenced
this pull request
Jan 23, 2020
https://dart.googlesource.com/sdk.git/+log/6aa7407d6309..e84bea25df23 git log 6aa7407..e84bea2 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 jensj@google.com [CFE] Fix crash in incremental compiler caused by async redirecting factory 2020-01-23 jensj@google.com [CFE] Incremental compiler refactor #1 2020-01-23 athom@google.com [release] Prepare CHANGELOG for 2.7.1 2020-01-23 sstrickl@google.com [vm] Refactor debug info handling code into a new package. 2020-01-23 jensj@google.com [CFE] Strong test can have linked dependencies 2020-01-23 johnniwinther@google.com [cfe] Check null nullable accesses and include null in inferred type for null aware expressions Created with: gclient setdep -r src/third_party/dart@e84bea25df23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: dart-vm-team@google.com
skia-flutter-autoroll
added a commit
that referenced
this pull request
Jun 26, 2020
https://dart.googlesource.com/sdk.git/+log/63cf56d92510..66c1b51c07b7 2020-06-26 joshualitt@google.com [dart2js] 20 dart2js tests ported to nnbd #1. 2020-06-26 joshualitt@google.com [dart2js] Support package json files in modular_test_suite. 2020-06-26 cskau@google.com [Test] Fixes sdk_hash_test broken by Windows line breaks. 2020-06-26 cskau@google.com [SDK] Adds an SDK hash to kernels and the VM. 2020-06-26 johnniwinther@google.com [cfe] Update CFE message to use 'null safety' instead of 'non-nullable' 2020-06-26 dacoharkes@google.com [vm/ffi] Remove try-catch from ffi trampoline if no handle scope 2020-06-26 sstrickl@google.com Add internal benchmarks to .gitignore. 2020-06-26 karlklose@google.com [infra] Remove support for approvals from compare_results 2020-06-26 whesse@google.com Roll benchmarks-internal to 15a6634bd60ed0b937ed5dbc874cba2da9865514 2020-06-26 kustermann@google.com [vm] Remove ARMv6 related code 2020-06-26 sgrekhov@unipro.ru [co19] Enable Language/Libraries_and_Scripts tests 2020-06-26 athom@google.com [co19] Roll co19 to e674d8ccb29250fa5d7ac886fa98c5962543fffc 2020-06-26 jensj@google.com Revert "[CFE] Set correct async markers in outline phase" 2020-06-26 karlklose@google.com [infra] Support posting results to staging in post_results_to_pubsub If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Jun 26, 2020
https://dart.googlesource.com/sdk.git/+log/63cf56d92510..648b5e9c6860 2020-06-26 srawlins@google.com Use ///-style doc comments in analyzer/lib 2020-06-26 jakemac@google.com update fixnum to nnbd version 2020-06-26 srawlins@google.com Use ///-style doc comments in analyzer/lib/src/generated 2020-06-26 cskau@google.com [Test] Skips sdk_hash_test for incompatible setups. 2020-06-26 srawlins@google.com Use ///-style doc comments in analyzer/lib/src/dart 2020-06-26 joshualitt@google.com [dart2js] 20 dart2js tests ported to nnbd #1. 2020-06-26 joshualitt@google.com [dart2js] Support package json files in modular_test_suite. 2020-06-26 cskau@google.com [Test] Fixes sdk_hash_test broken by Windows line breaks. 2020-06-26 cskau@google.com [SDK] Adds an SDK hash to kernels and the VM. 2020-06-26 johnniwinther@google.com [cfe] Update CFE message to use 'null safety' instead of 'non-nullable' 2020-06-26 dacoharkes@google.com [vm/ffi] Remove try-catch from ffi trampoline if no handle scope 2020-06-26 sstrickl@google.com Add internal benchmarks to .gitignore. 2020-06-26 karlklose@google.com [infra] Remove support for approvals from compare_results 2020-06-26 whesse@google.com Roll benchmarks-internal to 15a6634bd60ed0b937ed5dbc874cba2da9865514 2020-06-26 kustermann@google.com [vm] Remove ARMv6 related code 2020-06-26 sgrekhov@unipro.ru [co19] Enable Language/Libraries_and_Scripts tests 2020-06-26 athom@google.com [co19] Roll co19 to e674d8ccb29250fa5d7ac886fa98c5962543fffc 2020-06-26 jensj@google.com Revert "[CFE] Set correct async markers in outline phase" 2020-06-26 karlklose@google.com [infra] Support posting results to staging in post_results_to_pubsub If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
skia-flutter-autoroll
pushed a commit
that referenced
this pull request
Jun 26, 2020
Roll Dart version e24733e...63cf56d dart-lang/sdk@e24733ebd1 [ VM ] Change version output message to reference SDK instead of VM dart-lang/sdk@bb8d145616 Revert "[SDK] Adds an SDK hash to kernels and the VM." dart-lang/sdk@a558d576b7 Use ///-style doc comments in analyzer/tool dart-lang/sdk@c68fd58513 Use ///-style doc comments in analyzer/test dart-lang/sdk@48608ce9bc Migrate language_2/variance to NNBD. dart-lang/sdk@d4154ac6dc Migrate language_2/unsorted to NNBD. dart-lang/sdk@1ab82dee7e Migrate language_2/nonfunction_type_aliases to NNBD. dart-lang/sdk@648b5e9c68 Use ///-style doc comments in analyzer/lib dart-lang/sdk@04dd5edc6a update fixnum to nnbd version dart-lang/sdk@baa5717f78 Use ///-style doc comments in analyzer/lib/src/generated dart-lang/sdk@411c9cc992 [Test] Skips sdk_hash_test for incompatible setups. dart-lang/sdk@a89b7a4ef7 Use ///-style doc comments in analyzer/lib/src/dart dart-lang/sdk@66c1b51c07 [dart2js] 20 dart2js tests ported to nnbd #1. dart-lang/sdk@f4b19b8c2a [dart2js] Support package json files in modular_test_suite. dart-lang/sdk@1a278118dd [Test] Fixes sdk_hash_test broken by Windows line breaks. dart-lang/sdk@edde575dcd [SDK] Adds an SDK hash to kernels and the VM. dart-lang/sdk@d5120208b4 [cfe] Update CFE message to use 'null safety' instead of 'non-nullable' dart-lang/sdk@da39a4abff [vm/ffi] Remove try-catch from ffi trampoline if no handle scope dart-lang/sdk@15464a462f Add internal benchmarks to .gitignore. dart-lang/sdk@99144ed84d [infra] Remove support for approvals from compare_results dart-lang/sdk@98324c95d5 Roll benchmarks-internal to 15a6634bd60ed0b937ed5dbc874cba2da9865514 dart-lang/sdk@53807c1d79 [vm] Remove ARMv6 related code dart-lang/sdk@85d37c1ede [co19] Enable Language/Libraries_and_Scripts tests dart-lang/sdk@bcd2708843 [co19] Roll co19 to e674d8ccb29250fa5d7ac886fa98c5962543fffc dart-lang/sdk@b4b44d6b4b Revert "[CFE] Set correct async markers in outline phase" dart-lang/sdk@718df630ea [infra] Support posting results to staging in post_results_to_pubsub
skia-flutter-autoroll
pushed a commit
that referenced
this pull request
May 13, 2021
…tter#26117) This appears to have triggered reproducible failures in channels_integration_test_ios: [ +4 ms] 00:01 [32m+0[0m: channel suite step through[0m [+3744 ms] Unsupported value: Sun Mar 11 07:16:42 2018 of type __NSTaggedDate [ ] *** Assertion failure in void WriteValue(CFMutableDataRef, id)(), FlutterStandardCodec.mm:340 [ +2 ms] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Unsupported value for standard codec.' [ ] *** First throw call stack: [ ] (0x19d5bd9d8 0x1b1940b54 0x19d4cc50c 0x19e815238 0x1050031ec 0x104823f80 0x105003aac 0x1050009bc 0x104824e9c 0x105000b4c 0x104d0cc98 0x10501b398 0x104fb3c94 0x104fb72c4 0x19d53e3e0 0x19d53dfe4 0x19d53d4c4 0x19d537850 0x19d536ba0 0x1b429c598 0x19fe282f4 0x19fe2d874 0x1048257fc 0x19d215568) [ ] libc++abi.dylib: terminating with uncaught exception of type NSException [ +65 ms] Process 541 stopped [ ] * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT [ ] frame #0: 0x00000001c93e584c libsystem_kernel.dylib`__pthread_kill + 8 [ ] libsystem_kernel.dylib`__pthread_kill: [ ] -> 0x1c93e584c <+8>: b.lo 0x1c93e5868 ; <+36> [ ] 0x1c93e5850 <+12>: stp x29, x30, [sp, #-0x10]! [ ] 0x1c93e5854 <+16>: mov x29, sp [ ] 0x1c93e5858 <+20>: bl 0x1c93c2f5c ; cerror_nocancel [ ] Target 0: (Runner) stopped. Example builds: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20channels_integration_test_ios/828/overview * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20channels_integration_test_ios/829/overview * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20channels_integration_test_ios/830/overview * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20channels_integration_test_ios/831/overview Example Log: * https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8847377106855056784/+/u/run_channels_integration_test_ios/stdout This reverts commit 99021da.
skia-flutter-autoroll
pushed a commit
that referenced
this pull request
Jul 7, 2023
…visions) (flutter#43457)" (flutter#43466) This reverts commit a109e0b as it breaks flutter framework tests during subsequent roll. From flutter/flutter#130138: _TypeError: (#0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53)) ``` #0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53) #1 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #2 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:444:23) #3 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #4 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:419:54) #5 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #6 ListIterable.forEach (dart:_internal/iterable.dart:39:13) #7 _ProgramInfoBuilder.build (package:vm_snapshot_analysis/v8_profile.dart:338:16) #8 toProgramInfo (package:vm_snapshot_analysis/v8_profile.dart:282:8) #9 _treemapFromSnapshot (package:vm_snapshot_analysis/treemap.dart:158:27) #10 treemapFromJson (package:vm_snapshot_analysis/treemap.dart:85:5) flutter#11 SizeAnalyzer.analyzeZipSizeAndAotSnapshot (package:flutter_tools/src/base/analyze_size.dart:123:59) flutter#12 AndroidGradleBuilder._performCodeSizeAnalysis (package:flutter_tools/src/android/gradle.dart:623:60) flutter#13 AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:604:15) <asynchronous suspension> flutter#14 AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:242:5) <asynchronous suspension> flutter#15 BuildApkCommand.runCommand (package:flutter_tools/src/commands/build_apk.dart:116:5) <asynchronous suspension> flutter#16 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27) <asynchronous suspension> flutter#17 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19) <asynchronous suspension> flutter#18 CommandRunner.runCommand (package:args/command_runner.dart:212:13) <asynchronous suspension> ```
skia-flutter-autoroll
pushed a commit
that referenced
this pull request
Apr 6, 2024
The culprit test asks different threads to access some stack variables, but the stack might return earlier than the threads' completion. This PR fixes it by adding latches.
This test, despite being possibly fine for now, consistently triggers the following asan error when I make some unrelated trivial changes.
The thrown error:
<details>
<pre>
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EmbedderTest
[ RUN ] EmbedderTest.EmbedderThreadHostUseCustomThreadConfig
=================================================================
==14398==ERROR: AddressSanitizer: stack-use-after-scope on address 0x00031833b530 at pc 0x00013248d543 bp 0x000318740390 sp 0x00031873fb58
WRITE of size 4 at 0x00031833b530 thread T2
#0 0x13248d542 in pthread_getschedparam+0x3d2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x2c542)
#1 0x100577671 in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0::operator()() const+0x1a1 (embedder_unittests:x86_64+0x10030b671)
#2 0x1005774a2 in decltype(std::declval<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>()()) std::_fl::__invoke[abi:v15000]<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>(flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&)+0x22 (embedder_unittests:x86_64+0x10030b4a2)
#3 0x100577402 in void std::_fl::__invoke_void_return_wrapper<void, true>::__call<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>(flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&)+0x22 (embedder_unittests:x86_64+0x10030b402)
#4 0x1005773ba in std::_fl::__function::__alloc_func<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0, std::_fl::allocator<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0>, void ()>::operator()[abi:v15000]()+0x2a (embedder_unittests:x86_64+0x10030b3ba)
#5 0x1005734f6 in std::_fl::__function::__func<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0, std::_fl::allocator<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0>, void ()>::operator()()+0x26 (embedder_unittests:x86_64+0x1003074f6)
#6 0x10066a525 in std::_fl::__function::__value_func<void ()>::operator()[abi:v15000]() const+0x105 (embedder_unittests:x86_64+0x1003fe525)
#7 0x10066a3f2 in std::_fl::function<void ()>::operator()() const+0x22 (embedder_unittests:x86_64+0x1003fe3f2)
#8 0x100c229dc in fml::MessageLoopImpl::FlushTasks(fml::FlushType)+0x37c (embedder_unittests:x86_64+0x1009b69dc)
#9 0x100c22577 in fml::MessageLoopImpl::RunExpiredTasksNow()+0x27 (embedder_unittests:x86_64+0x1009b6577)
#10 0x100c8aa2f in fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*)+0x2f (embedder_unittests:x86_64+0x100a1ea2f)
flutter#11 0x7ff817b54508 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__+0x13 (CoreFoundation:x86_64+0x97508)
flutter#12 0x7ff817b540b8 in __CFRunLoopDoTimer+0x310 (CoreFoundation:x86_64+0x970b8)
flutter#13 0x7ff817b53ce9 in __CFRunLoopDoTimers+0x11c (CoreFoundation:x86_64+0x96ce9)
flutter#14 0x7ff817b380ac in __CFRunLoopRun+0x83b (CoreFoundation:x86_64+0x7b0ac)
flutter#15 0x7ff817b372a8 in CFRunLoopRunSpecific+0x22c (CoreFoundation:x86_64+0x7a2a8)
flutter#16 0x100c8b155 in fml::MessageLoopDarwin::Run()+0x305 (embedder_unittests:x86_64+0x100a1f155)
flutter#17 0x100c223d0 in fml::MessageLoopImpl::DoRun()+0x150 (embedder_unittests:x86_64+0x1009b63d0)
flutter#18 0x100c1f1fa in fml::MessageLoop::Run()+0x2a (embedder_unittests:x86_64+0x1009b31fa)
flutter#19 0x100c7baa4 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0::operator()() const+0x194 (embedder_unittests:x86_64+0x100a0faa4)
flutter#20 0x100c7b8e2 in decltype(std::declval<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>()()) std::_fl::__invoke[abi:v15000]<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&)+0x22 (embedder_unittests:x86_64+0x100a0f8e2)
#21 0x100c7b842 in void std::_fl::__invoke_void_return_wrapper<void, true>::__call<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&)+0x22 (embedder_unittests:x86_64+0x100a0f842)
#22 0x100c7b7fa in std::_fl::__function::__alloc_func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()[abi:v15000]()+0x2a (embedder_unittests:x86_64+0x100a0f7fa)
#23 0x100c77ad6 in std::_fl::__function::__func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()()+0x26 (embedder_unittests:x86_64+0x100a0bad6)
#24 0x10066a525 in std::_fl::__function::__value_func<void ()>::operator()[abi:v15000]() const+0x105 (embedder_unittests:x86_64+0x1003fe525)
#25 0x10066a3f2 in std::_fl::function<void ()>::operator()() const+0x22 (embedder_unittests:x86_64+0x1003fe3f2)
#26 0x100c75388 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::operator()(void*) const+0xe8 (embedder_unittests:x86_64+0x100a09388)
#27 0x100c75227 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::__invoke(void*)+0xc7 (embedder_unittests:x86_64+0x100a09227)
#28 0x1324b3e76 in asan_thread_start(void*)+0x46 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x52e76)
#29 0x7ff817a5c18a in _pthread_start+0x62 (libsystem_pthread.dylib:x86_64+0x618a)
#30 0x7ff817a57ae2 in thread_start+0xe (libsystem_pthread.dylib:x86_64+0x1ae2)
Address 0x00031833b530 is located in stack of thread T0 at offset 144 in frame
#0 0x1002d051f in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()+0xf (embedder_unittests:x86_64+0x10006451f)
This frame has 12 object(s):
[32, 40) 'thread_host' (line 3445)
[64, 112) 'ref.tmp' (line 3446)
[144, 148) 'ui_policy' (line 3449) <== Memory access at offset 144 is inside this variable
[160, 168) 'ui_param' (line 3450)
[192, 200) 'ref.tmp2' (line 3452)
[224, 272) 'ref.tmp5' (line 3452)
[304, 320) 'agg.tmp'
[336, 340) 'io_policy' (line 3458)
[352, 360) 'io_param' (line 3459)
[384, 392) 'ref.tmp6' (line 3460)
[416, 464) 'ref.tmp10' (line 3460)
[496, 512) 'agg.tmp11'
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
(longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-use-after-scope (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x2c542) in pthread_getschedparam+0x3d2
Shadow bytes around the buggy address:
0x00031833b280: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x00031833b300: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x00031833b380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x00031833b400: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x00031833b480: 00 00 00 00 f1 f1 f1 f1 00 f2 f2 f2 f8 f8 f8 f8
=>0x00031833b500: f8 f8 f2 f2 f2 f2[f8]f2 f8 f2 f2 f2 f8 f2 f2 f2
0x00031833b580: f8 f8 f8 f8 f8 f8 f2 f2 f2 f2 00 00 f2 f2 f8 f2
0x00031833b600: f8 f2 f2 f2 f8 f2 f2 f2 f8 f8 f8 f8 f8 f8 f2 f2
0x00031833b680: f2 f2 00 00 f3 f3 f3 f3 00 00 00 00 00 00 00 00
0x00031833b700: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x00031833b780: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
Thread T2 created by T0 here:
#0 0x1324ae92d in pthread_create+0x5d (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x4d92d)
#1 0x100c73901 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)+0x401 (embedder_unittests:x86_64+0x100a07901)
#2 0x100c73cca in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)+0x2a (embedder_unittests:x86_64+0x100a07cca)
#3 0x100c748c9 in std::_fl::__unique_if<fml::ThreadHandle>::__unique_single std::_fl::make_unique[abi:v15000]<fml::ThreadHandle, fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&&)+0x149 (embedder_unittests:x86_64+0x100a088c9)
#4 0x100c74335 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)+0x255 (embedder_unittests:x86_64+0x100a08335)
#5 0x100c746b2 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)+0x32 (embedder_unittests:x86_64+0x100a086b2)
#6 0x106ee0b1a in std::_fl::__unique_if<fml::Thread>::__unique_single std::_fl::make_unique[abi:v15000]<fml::Thread, std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig&>(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig&)+0x4a (embedder_unittests:x86_64+0x106c74b1a)
#7 0x106ee08e8 in flutter::ThreadHost::CreateThread(flutter::ThreadHost::Type, std::_fl::optional<fml::Thread::ThreadConfig>, flutter::ThreadHost::ThreadHostConfig const&) const+0x1b8 (embedder_unittests:x86_64+0x106c748e8)
#8 0x106ee1466 in flutter::ThreadHost::ThreadHost(flutter::ThreadHost::ThreadHostConfig const&)+0x2f6 (embedder_unittests:x86_64+0x106c75466)
#9 0x106ee19ca in flutter::ThreadHost::ThreadHost(flutter::ThreadHost::ThreadHostConfig const&)+0x2a (embedder_unittests:x86_64+0x106c759ca)
#10 0x100b6f730 in flutter::EmbedderThreadHost::CreateEngineManagedThreadHost(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&)+0x3a0 (embedder_unittests:x86_64+0x100903730)
flutter#11 0x100b6e51c in flutter::EmbedderThreadHost::CreateEmbedderOrEngineManagedThreadHost(FlutterCustomTaskRunners const*, std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&)+0xcc (embedder_unittests:x86_64+0x10090251c)
flutter#12 0x1002d0748 in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()+0x238 (embedder_unittests:x86_64+0x100064748)
flutter#13 0x1089ce93b in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x21b (embedder_unittests:x86_64+0x10876293b)
flutter#14 0x108955bdf in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x2cf (embedder_unittests:x86_64+0x1086e9bdf)
flutter#15 0x108955755 in testing::Test::Run()+0x3a5 (embedder_unittests:x86_64+0x1086e9755)
flutter#16 0x108957b23 in testing::TestInfo::Run()+0x593 (embedder_unittests:x86_64+0x1086ebb23)
flutter#17 0x10895a8f2 in testing::TestSuite::Run()+0x6e2 (embedder_unittests:x86_64+0x1086ee8f2)
flutter#18 0x108977d7a in testing::internal::UnitTestImpl::RunAllTests()+0xb9a (embedder_unittests:x86_64+0x10870bd7a)
flutter#19 0x1089ee88b in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)+0x21b (embedder_unittests:x86_64+0x10878288b)
flutter#20 0x1089770ac in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)+0x2cc (embedder_unittests:x86_64+0x10870b0ac)
#21 0x108976c3b in testing::UnitTest::Run()+0x28b (embedder_unittests:x86_64+0x10870ac3b)
#22 0x1083e45e2 in RUN_ALL_TESTS()+0x22 (embedder_unittests:x86_64+0x1081785e2)
#23 0x1083e43c8 in main+0x6e8 (embedder_unittests:x86_64+0x1081783c8)
#24 0x213ff0365 (<unknown module>)
==14398==ABORTING
[1] 14398 abort ../out/host_debug_unopt/embedder_unittests
</pre>
</details>
The changes I made (isolated from a larger change, therefore it doesn't seem reasonable by itself):
```diff
// shell/common/platform_view.cc, L33
void PlatformView::DispatchPointerDataPacket(
std::unique_ptr<PointerDataPacket> packet) {
- delegate_.OnPlatformViewDispatchPointerDataPacket(
- pointer_data_packet_converter_.Convert(std::move(packet)));
+ delegate_.OnPlatformViewDispatchPointerDataPacket(std::move(packet));
}
```
Base engine rev: de2a73c
Environment: Macbook with M1 Max Chip, OS 14.4.1
Compiling with:
```
./engine/src/flutter/tools/gn --goma --unoptimized --asan --xcode-symlinks
./depot_tools/ninja -j200 -C ./engine/src/out/host_debug_unopt
./out/host_debug_unopt/embedder_unittests
```
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
skia-flutter-autoroll
added a commit
that referenced
this pull request
Aug 28, 2024
https://skia.googlesource.com/skia.git/+log/d55406ca32e9..f5f3648c25ec 2024-08-28 jlavrova@google.com Split FreeType & FontConfig, step #1 2024-08-28 danieldilan@google.com Reland "GPU support for F16F16F16x SkColorType." 2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fb93bdd85957 to 8b35b106dd98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Aug 28, 2024
https://skia.googlesource.com/skia.git/+log/d55406ca32e9..0d8d9d2974fa 2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 03b32d20940d to d90557b380fa (4 revisions) 2024-08-28 jlavrova@google.com Split FreeType & FontConfig, step #1 2024-08-28 danieldilan@google.com Reland "GPU support for F16F16F16x SkColorType." 2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fb93bdd85957 to 8b35b106dd98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Aug 28, 2024
) https://skia.googlesource.com/skia.git/+log/d55406ca32e9..0d8d9d2974fa 2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 03b32d20940d to d90557b380fa (4 revisions) 2024-08-28 jlavrova@google.com Split FreeType & FontConfig, step #1 2024-08-28 danieldilan@google.com Reland "GPU support for F16F16F16x SkColorType." 2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fb93bdd85957 to 8b35b106dd98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Aug 28, 2024
https://skia.googlesource.com/skia.git/+log/0d8d9d2974fa..e37b6b198016 2024-08-28 jlavrova@google.com Revert "Split FreeType & FontConfig, step #1" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Aug 29, 2024
https://skia.googlesource.com/skia.git/+log/0d8d9d2974fa..e37b6b198016 2024-08-28 jlavrova@google.com Revert "Split FreeType & FontConfig, step #1" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Sep 3, 2024
https://skia.googlesource.com/skia.git/+log/2d5a75027691..5515c08c2e44 2024-09-03 beaufort.francois@gmail.com [webgpu-headers] Add macro for dropping "descriptor" 2024-09-03 jlavrova@google.com Reland "Split FreeType & FontConfig, step #1" 2024-09-03 lukasza@chromium.org [rust png] Minimal `onGetFrameInfo` to support non-animated images. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Sep 3, 2024
) https://skia.googlesource.com/skia.git/+log/2d5a75027691..5515c08c2e44 2024-09-03 beaufort.francois@gmail.com [webgpu-headers] Add macro for dropping "descriptor" 2024-09-03 jlavrova@google.com Reland "Split FreeType & FontConfig, step #1" 2024-09-03 lukasza@chromium.org [rust png] Minimal `onGetFrameInfo` to support non-animated images. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Sep 3, 2024
https://skia.googlesource.com/skia.git/+log/5515c08c2e44..43b4f389bab1 2024-09-03 jvanverth@google.com [graphite] Rename clip shader block to be more generic. 2024-09-03 jlavrova@google.com Revert "Reland "Split FreeType & FontConfig, step #1"" 2024-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from aa237b66d8cc to 5e29f5c97fc4 (1 revision) 2024-09-03 ccameron@chromium.org SkAndroidCodec: Add getAndroidGainmap that populates an SkAndroidCodec 2024-09-03 kjlubick@google.com Apply some clang-tidy suggestions to graphite code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Sep 3, 2024
https://skia.googlesource.com/skia.git/+log/5515c08c2e44..0d9333e72a39 2024-09-03 robertphillips@google.com [graphite] Add centralized app flag handling 2024-09-03 nicolettep@google.com Indicate we are able to root on Pixel5 devices 2024-09-03 jvanverth@google.com [graphite] Make circular_rrect_clip snippet output coverage instead. 2024-09-03 jvanverth@google.com [graphite] Rename clip shader block to be more generic. 2024-09-03 jlavrova@google.com Revert "Reland "Split FreeType & FontConfig, step #1"" 2024-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from aa237b66d8cc to 5e29f5c97fc4 (1 revision) 2024-09-03 ccameron@chromium.org SkAndroidCodec: Add getAndroidGainmap that populates an SkAndroidCodec 2024-09-03 kjlubick@google.com Apply some clang-tidy suggestions to graphite code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Sep 3, 2024
) https://skia.googlesource.com/skia.git/+log/5515c08c2e44..0d9333e72a39 2024-09-03 robertphillips@google.com [graphite] Add centralized app flag handling 2024-09-03 nicolettep@google.com Indicate we are able to root on Pixel5 devices 2024-09-03 jvanverth@google.com [graphite] Make circular_rrect_clip snippet output coverage instead. 2024-09-03 jvanverth@google.com [graphite] Rename clip shader block to be more generic. 2024-09-03 jlavrova@google.com Revert "Reland "Split FreeType & FontConfig, step #1"" 2024-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from aa237b66d8cc to 5e29f5c97fc4 (1 revision) 2024-09-03 ccameron@chromium.org SkAndroidCodec: Add getAndroidGainmap that populates an SkAndroidCodec 2024-09-03 kjlubick@google.com Apply some clang-tidy suggestions to graphite code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Sep 19, 2024
https://skia.googlesource.com/skia.git/+log/9d16a74c860a..ca94a5369af5 2024-09-19 jlavrova@google.com Reland "Reland "Split FreeType & FontConfig, step #1"" 2024-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e80717cdb17e to e4d224c16ab4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added a commit
that referenced
this pull request
Sep 19, 2024
) https://skia.googlesource.com/skia.git/+log/9d16a74c860a..ca94a5369af5 2024-09-19 jlavrova@google.com Reland "Reland "Split FreeType & FontConfig, step #1"" 2024-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e80717cdb17e to e4d224c16ab4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.