Random change for Gitpod demo #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no point in doing the compatibility check when spinning up a new Gitpod workspace, so add an option to build.sh to skip it, and use it for the Gitpod build. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Change the Origin to an interface, from an abstract class, and change its `bind` protocol to return an `OriginBindConfig` interface. This is in preparation for handling Origin Groups in aws#9109 - when time comes to handle Origin Groups, we will add a new (optional) property to `OriginBindConfig`, of type `CfnDistribution.OriginGroupProperty`, and handle it in `Distribution`. BREAKING CHANGE: the property Origin.domainName has been removed ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…aws#9326) Prior to this change, there were both HttpOrigin and S3Origin classes in both the aws-cloudfront and aws-cloudfront-origins module. The behaviors of the S3Origin classes were also slightly different. This change removes the duplication by removing the aws-cloudfront versions of the origins. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My demo PR for Gitpod.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license