Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for protocols that aren't tcp #611

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Conversation

nivasan1
Copy link
Contributor

In This PR

  • I account for URL schemes that are not http (tcp, etc) when stripping schemes from GRPC target addresses

Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to reproduce the issue that was occurring?

@aljo242
Copy link
Contributor

aljo242 commented Jul 18, 2024

E2E tests are now failing due to this change

@nivasan1 nivasan1 requested a review from aljo242 July 18, 2024 17:38
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.51%. Comparing base (6470e30) to head (2c28de5).

Files Patch % Lines
pkg/grpc/client.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   56.52%   56.51%   -0.02%     
==========================================
  Files         249      249              
  Lines       12966    12971       +5     
==========================================
+ Hits         7329     7330       +1     
- Misses       4930     4933       +3     
- Partials      707      708       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nivasan1 nivasan1 merged commit 7c1dfab into main Jul 18, 2024
16 checks passed
@nivasan1 nivasan1 deleted the nv/port-parsing-error branch July 18, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants