fix: account for protocols that aren't tcp

pkg/grpc/client.go

@@ -1,7 +1,9 @@
 package grpc
 
 import (
-	"strings"
+	"fmt"
+	"net/url"
+	"net"
 
 	grpc "google.golang.org/grpc"
 )
@@ -13,12 +15,23 @@
 	target string,
 	opts ...grpc.DialOption,
 ) (conn *grpc.ClientConn, err error) {
-	// strip the scheme from the target
-	target = strings.TrimPrefix(strings.TrimPrefix(target, "http://"), "https://")
+	// check if this is a host:port URI, if so continue,
+	// otherwise, parse the URL and extract the host and port
+	host, port, err := net.SplitHostPort(target)
+	if err != nil {
+		// parse the URL
+		ip, err := url.Parse(target)
+		if err != nil {
+			return nil, err
+		}
+
+		// extract the host and port
+		host, port = ip.Hostname(), ip.Port()
+	}
 
 	// create a new client
 	return grpc.NewClient(
-		target,
+		fmt.Sprintf("%s:%s", host, port),
 		opts...,
 	)
 }

pkg/grpc/client_test.go

@@ -0,0 +1,60 @@
+package grpc_test
+
+import (
+	"fmt"
+	"net"
+	"testing"
+	"context"
+
+	slinkygrpc "github.com/skip-mev/slinky/pkg/grpc"
+	"github.com/stretchr/testify/require"
+	"google.golang.org/grpc"
+	"google.golang.org/grpc/credentials/insecure"
+	"google.golang.org/grpc/reflection"
+	reflectionpb "google.golang.org/grpc/reflection/grpc_reflection_v1alpha"
+)
+
+func TestClient(t *testing.T) {
+	// spin up a mock grpc-server + test connecting to it via diff addresses
+	srv := grpc.NewServer()
+
+	// listen on a random open port
+	lis, err := net.Listen("tcp", "localhost:0")
+	if err != nil {
+		t.Fatalf("failed to listen: %v", err)
+	}
+	// register reflection service on the server
+	reflection.Register(srv)
+
+	// start the server
+	go func() {
+		if err := srv.Serve(lis); err != nil {
+			t.Fatalf("failed to serve: %v", err)
+		}
+	}()
+
+	_, port, err := net.SplitHostPort(lis.Addr().String())
+	if err != nil {
+		t.Fatalf("failed to parse address: %v", err)
+	}
+
+	t.Run("try dialing via non supported GRPC target URL (i.e tcp prefix)", func(t *testing.T) {
+		// try dialing via non supported GRPC target URL (i.e tcp prefix)
+		client, err := slinkygrpc.NewClient(fmt.Sprintf("tcp://localhost:%s", port), grpc.WithTransportCredentials(insecure.NewCredentials()))
+		require.NoError(t, err)
+
+		// ping the server
+		_, err = reflectionpb.NewServerReflectionClient(client).ServerReflectionInfo(context.Background())
+		require.NoError(t, err)
+	})
+
+	t.Run("try dialing via supported GRPC target URL (i.e host:port)", func(t *testing.T) {
+		// try dialing via supported GRPC target URL (i.e host:port)
+		client, err := slinkygrpc.NewClient(fmt.Sprintf("localhost:%s", port), grpc.WithTransportCredentials(insecure.NewCredentials()))
+		require.NoError(t, err)
+
+		// ping the server
+		_, err = reflectionpb.NewServerReflectionClient(client).ServerReflectionInfo(context.Background())
+		require.NoError(t, err)
+	})
+}