Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/15 authorize #24

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Feature/15 authorize #24

wants to merge 6 commits into from

Conversation

toothless8392
Copy link
Collaborator

@toothless8392 toothless8392 commented Mar 13, 2024 •
edited
Loading

Description

  1. The authorization process is involved in adminRouter.
  2. Routers of authentication are slightly revised.
  3. Study APIs are written with TS, and the names of files are changed. (user.js => userStudy.js, admin.ts => adminStudy.ts)

Additional context

이번엔 드디어 해치웠나?

Closes #14
Closes #15

@toothless8392 toothless8392 added feat 새로운 기능 추가 chore 사소한 작업 labels Mar 13, 2024
aptheparker
aptheparker reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@aptheparker aptheparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 pr 브랜치는 어디서부터 checkout 하신건가요?
다른 pr에 있는 내용이 중복되는거 같네요!

@toothless8392
Copy link
Collaborator Author

이 pr 브랜치는 어디서부터 checkout 하신건가요? 다른 pr에 있는 내용이 중복되는거 같네요!

그 pr 닫고 이걸로 통합하는 게 좋을 것 같습니다.

@aptheparker aptheparker reopened this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aptheparker aptheparker aptheparker approved these changes

@Tg-desing Tg-desing Awaiting requested review from Tg-desing

@B0XERCAT B0XERCAT Awaiting requested review from B0XERCAT

@juminzoomout juminzoomout Awaiting requested review from juminzoomout

Assignees

@toothless8392 toothless8392

Labels
chore 사소한 작업 feat 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Authorization (isAdmin) Add Authentication (Login Function)
2 participants
@toothless8392 @aptheparker