-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade Kamon to 2.1.12 #101
Conversation
In the application.conf configuration path need to be changed to : kamon {
environment.service = "kafka-message-scheduler"
instrumentation.akka.filters {
"actors.track" {
includes = ["kafka-message-scheduler/user/scheduling-actor", "kafka-message-scheduler/user/publisher-actor"]
excludes = ["kafka-message-scheduler/system/**"]
}
} as per Kamon docs |
Good spot Tanya - final paragraph of the migration guide explains as well: https://kamon.io/docs/latest/guides/migration/from-1.x-to-2.0/#filter-changes |
@bcarter97 I think there are couple of parts of the migration guide we should revisit, even though we did see metrics being produced when we tested this, they might not be all the right metrics we expect https://kamon.io/docs/latest/guides/migration/from-1.x-to-2.0/#there-is-a-new-kamoninit-method - https://kamon.io/docs/latest/guides/migration/from-1.x-to-2.0/#we-moved-from-aspectj-to-kanela - I think there is an aspectj dependency in build.sbt at the moment, I expect that can be changed to kanela or removed all together. |
Would it be easier to import just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments but looks good!
Can we update the monitoring paragraph a little in the README.md. I think the link to 'kamon prometheus reporter' is old. Might be worth adding a sentence that prometheus is included with the docker compose as an example. |
* Use jitpack kafka-topic-loader instead of bintray * Revert kamon-bundle use from #101 * Bump kamon to 2.2.2 * Make kamon-jmx-collector unmanaged
Description
nanohttpd
peer dependencyMigration notes
Kamon.init()
is called early in the application which bootstraps the metric reportingstopAllReports
has been renamed ->stopAllModules
refine
has been renamed ->withTags
Other changes