Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kamon bundle #104

Merged
merged 4 commits into from
Jul 20, 2021
Merged

Remove kamon bundle #104

merged 4 commits into from
Jul 20, 2021

Conversation

paulaylingdev
Copy link
Contributor

@paulaylingdev paulaylingdev commented Jul 16, 2021 •
edited
Loading

Closes #103

  • Fixes bintray / kafka-topic-loader dependency by using jitpack
  • Reverts kamon dependencies included to core, akka and prometheus. Same as before upgrade Kamon to 2.1.12 #101
  • Kamon bumped to latest version 2.2.2
  • kamon-jmx-collector and its dependency jmx-collector changed to unmanaged dependencies

@paulaylingdev
Copy link
Contributor Author

Build is failing due to Segence/kamon-jmx-collector no longer being available publicly.

We have a few options going forward:

  • Fork kamon-jmx-collector and publish jars somewhere public.
  • Include kamon-jmx-collector as an umanaged dependency.
  • Remove kamon-jmx-collector as a dependency.

@btanyab btanyab merged commit 6a99c82 into master Jul 20, 2021
@paulaylingdev paulaylingdev deleted the remove-kamon-bundle branch July 26, 2021 09:46
@bcarter97 bcarter97 added this to the 0.3.0 release milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-hazell peter-hazell peter-hazell approved these changes

@btanyab btanyab btanyab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0 release
Development

Successfully merging this pull request may close these issues.

Kamon Kafka Instrumentation - ByteStreamReader error
4 participants
@paulaylingdev @peter-hazell @btanyab @bcarter97