Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: multi-select/radio button block elements are still unsupported #342

Closed
4 of 9 tasks
seratch opened this issue Dec 15, 2019 · 0 comments · Fixed by #344
Closed
4 of 9 tasks

TypeScript: multi-select/radio button block elements are still unsupported #342

seratch opened this issue Dec 15, 2019 · 0 comments · Fixed by #344
Assignees
@seratch
Labels
enhancement M-T: A feature request for new functionality TypeScript-specific

Comments

@seratch
Copy link
Member

seratch commented Dec 15, 2019 •
edited
Loading

Description

For TypeScript users, block_actions doesn't support newly added elements(specifically, multi-select ones and radio buttons) yet. We just need to add those to BlockElementAction.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

  • package version: 1.4.1
  • node version: any
  • OS version(s): any

Steps to reproduce:

  1. submit a block_actions request with multi-select block elements and try to parse the payload in TypeScript

Expected result:

Can do that.

Actual result:

TypeScript compiler is not happy with it/

Attachments:

None
@seratch seratch added enhancement M-T: A feature request for new functionality TypeScript-specific labels Dec 15, 2019
@seratch seratch self-assigned this Dec 15, 2019
@seratch seratch mentioned this issue Dec 15, 2019
Merged
2 tasks
@seratch seratch changed the title multi-select block elements are still unsupported multi-select/radio button block elements are still unsupported Dec 16, 2019
@seratch seratch changed the title multi-select/radio button block elements are still unsupported TypeScript: multi-select/radio button block elements are still unsupported Dec 16, 2019
seratch added a commit to seratch/bolt-js that referenced this issue Dec 16, 2019
@seratch
Fix slackapi#342 TypeScript: multi-select/radio button block elements…
569812e 
… are still unsupported
seratch added a commit to seratch/bolt-js that referenced this issue Dec 16, 2019
@seratch
Fix slackapi#342 TypeScript: multi-select/radio button block elements…
6896492 
… are still unsupported
@seratch seratch mentioned this issue Dec 16, 2019
Merged
2 tasks
seratch added a commit that referenced this issue Dec 16, 2019
@seratch
Merge pull request #344 from seratch/more-block-elements
4519546 
Fix #342 TypeScript: multi-select/radio button block elements are still unsupported
@Falci Falci mentioned this issue Feb 3, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality TypeScript-specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #342 TypeScript: multi-select/radio button block elements are still unsupported seratch/bolt-js
1 participant
@seratch