Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #341 - Make channel file in block_actions payload optional (+ add view field) #343

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

seratch
Copy link
Member

@seratch seratch commented Dec 15, 2019

Summary

This pull request fixes issue #341 that affects TypeScript users. In connection with this, I've added the missing view field for the cases of modals and Home tab.

Also, I noticed block_actions payload in TypeScript doesn't support multi-select block elements yet. I filed another issue #342 and will work on it in a separate pull request.

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality semver:patch TypeScript-specific labels Dec 15, 2019
@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #343 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   73.35%   73.35%           
=======================================
  Files           7        7           
  Lines         503      503           
  Branches      146      146           
=======================================
  Hits          369      369           
  Misses        102      102           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252aaf2...c5738c2. Read the comment docs.

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @seratch!

@seratch seratch merged commit 1845aa5 into slackapi:master Dec 16, 2019
@seratch seratch deleted the block_actions-payload branch December 16, 2019 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:patch TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants