-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View type missing optional id from response #436
Labels
bug
M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
TypeScript-specific
Comments
seratch
added
bug
M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
TypeScript-specific
labels
Mar 24, 2020
@tteltrab Thank you for taking the time to flag this. I'll work on the fix. |
seratch
added a commit
to seratch/bolt-js
that referenced
this issue
Mar 24, 2020
2 tasks
seratch
added a commit
to seratch/bolt-js
that referenced
this issue
Mar 24, 2020
2 tasks
stevengill
added a commit
that referenced
this issue
Mar 24, 2020
Fix #436 View type missing optional id from response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
TypeScript-specific
Description
In the docs, in re: updating views
Typescript bindings for View don't have an id property on the interface, which is causing errors. https://github.com/slackapi/node-slack-sdk/blob/master/packages/types/src/index.ts#L35
Not sure about this type, also not sure about opening the issue here, I understand the type is there ^ but it seems the intent of the View type is to be the view object sent with
views.open
API call, not to handle the ViewResponse which has an id.What type of issue is this? (place an
x
in one of the[ ]
)Bugfeature? It's an enhancement to the type bindings, but I can't reference a value that is definitely there in the response because of it when using typescript (have to give it the good old
@ts-ignore
).Requirements (place an
x
in each of the[ ]
)Bug Report
Reproducible in:
package version: 1.8.0
node version: 12.14.1
OS version(s): MacOS 10.15.1
Steps to reproduce:
Expected result:
Should be able to reference
body.view.id
Actual result:
TypeError
Attachments:
The text was updated successfully, but these errors were encountered: