Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Fix #436 View type missing optional id from response #438

Closed
wants to merge 1 commit into from

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 24, 2020

Summary

This pull request is the v2 branch fix for #436 - cherry-picked from #437

Requirements (place an x in each [ ])

@seratch seratch self-assigned this Mar 24, 2020
@seratch seratch added this to the V2 milestone Mar 24, 2020
@seratch seratch added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Mar 24, 2020
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #438 into @slack/bolt@next will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           @slack/bolt@next     #438   +/-   ##
=================================================
  Coverage             85.60%   85.60%           
=================================================
  Files                     7        7           
  Lines                   514      514           
  Branches                149      149           
=================================================
  Hits                    440      440           
  Misses                   50       50           
  Partials                 24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1fc9e...cdd9e71. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented Mar 24, 2020

@seratch instead of opening a second PR for the @slack/bolt@next branch, i think its easier to allow the PR to merge on master and then merge master into @slack/bolt@next.

@stevengill can you confirm this is how we want to handle this scenario?

@seratch
Copy link
Member Author

seratch commented Mar 24, 2020

Yes, either is fine to me. I just wanted to reduce y’all’s efforts on this considering this timing (last minute before v2 release)

@stevengill
Copy link
Member

agree with @aoberoi!

Any PR that needs to hit the 1.x branch should be going to master and merged into next from master.

Any PR that is next specific can go straight to next

Closing this PR.

@stevengill stevengill closed this Mar 24, 2020
@seratch seratch deleted the issue-436-v2 branch March 24, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants