Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next-gen docs] Update next-gen capitalization of terms and also trim down on the getting started guide #1709

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

hello-ashleyintech
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech commented Jan 11, 2023

Summary

This PR accomplishes the following:

  • Updates next-gen terms to lowercase per this discussion
  • Update next-gen Getting Started guide so it's trimmed down more, aligns more with Bolt Python's guide, and also is easier to follow

Requirements (place an x in each [ ])

@hello-ashleyintech hello-ashleyintech added the docs M-T: Documentation work only label Jan 11, 2023
@hello-ashleyintech hello-ashleyintech self-assigned this Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1709 (42bbf1e) into main (527276f) will not change coverage.
The diff coverage is n/a.

❗ Current head 42bbf1e differs from pull request most recent head 3872753. Consider uploading reports for the commit 3872753 to get more accurate results

@@           Coverage Diff           @@
##             main    #1709   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          18       18           
  Lines        1502     1502           
  Branches      437      437           
=======================================
  Hits         1233     1233           
  Misses        172      172           
  Partials       97       97           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

docs/_future/app_manifests.md Outdated Show resolved Hide resolved
docs/_future/getting_started_future.md Outdated Show resolved Hide resolved
Copy link
Contributor

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions for other things that maybe shouldn't be capitalized when used at the start of a sentence - Datastores, Manifest, namely.

And then also some nits on wording!

Copy link
Contributor

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@hello-ashleyintech hello-ashleyintech merged commit 3e1d18e into main Jan 12, 2023
@hello-ashleyintech hello-ashleyintech deleted the next-gen-doc-updates branch January 12, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants