Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update the redirected repo homepage url to postfix js #2370

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Dec 16, 2024

Summary

This PR updates the repository field of this package to use the most recent slackapi/bolt-js path of this repo! 👾

Preview

NPM: https://www.npmjs.com/package/@slack/bolt

Notes

Docs: https://docs.npmjs.com/cli/v10/configuring-npm/package-json?v=true#repository

Requirements

@zimeg zimeg added this to the 4.1.2 milestone Dec 16, 2024
@zimeg zimeg self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (9846ce8) to head (9d1a358).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2370   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am slightly reluctant to changing the metadata information of these projects, @seratch pointed this out to me in the past 🙇

I'm not sure what type of effects this may have to the end users my research did not yield much, but this does seem like a trivial change since the current url redirects to the new url 🤔

@zimeg zimeg requested a review from seratch December 16, 2024 21:45
@zimeg
Copy link
Member Author

zimeg commented Dec 16, 2024

@WilliamBergamin I appreciate the hesitation in this change! I'm also not finding many downstream effects of this change other than the npm repo command, and might consider it a fix since we're redirecting already.

I am also curious if @seratch has more callouts to make! I'll hold off on merging this right now, but I plan to follow up with a release once the time is right 🚀

@seratch
Copy link
Member

seratch commented Dec 17, 2024

@WilliamBergamin @zimeg Thanks for working on this! My past comment for the python project meant we should not eliminate those metadata. So, updating some properties to make them up-to-date should not cause any inconvenience to our users. We can merge this PR!

@zimeg
Copy link
Member Author

zimeg commented Dec 17, 2024

@WilliamBergamin @seratch Thank y'all both for checking on this! Then it's merge time! 🚢 💨

@zimeg zimeg merged commit c091510 into main Dec 17, 2024
18 checks passed
@zimeg zimeg deleted the zimeg-build-repository-path branch December 17, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants