-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update the redirected repo homepage url to postfix js #2370
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2370 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 36 36
Lines 7472 7472
Branches 653 653
=======================================
Hits 6919 6919
Misses 545 545
Partials 8 8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am slightly reluctant to changing the metadata information of these projects, @seratch pointed this out to me in the past 🙇
I'm not sure what type of effects this may have to the end users my research did not yield much, but this does seem like a trivial change since the current url redirects to the new url 🤔
@WilliamBergamin I appreciate the hesitation in this change! I'm also not finding many downstream effects of this change other than the I am also curious if @seratch has more callouts to make! I'll hold off on merging this right now, but I plan to follow up with a release once the time is right 🚀 |
@WilliamBergamin @zimeg Thanks for working on this! My past comment for the python project meant we should not eliminate those metadata. So, updating some properties to make them up-to-date should not cause any inconvenience to our users. We can merge this PR! |
@WilliamBergamin @seratch Thank y'all both for checking on this! Then it's merge time! 🚢 💨 |
Summary
This PR updates the
repository
field of this package to use the most recentslackapi/bolt-js
path of this repo! 👾Preview
NPM: https://www.npmjs.com/package/@slack/bolt
Notes
Docs: https://docs.npmjs.com/cli/v10/configuring-npm/package-json?v=true#repository
Requirements