-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring with pyproject.toml #1436
Configuring with pyproject.toml #1436
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1436 +/- ##
==========================================
- Coverage 85.59% 85.44% -0.15%
==========================================
Files 111 111
Lines 12128 12113 -15
==========================================
- Hits 10381 10350 -31
- Misses 1747 1763 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! You can merge this after verifying the test.pypi.org works with it
@WilliamBergamin An external contribution #1435 to add PyPy support etc. was merged. Can you update this PR accordingly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @WilliamBergamin,
I've found a few inclusions of slack_bolt
to this PR which, I suppose, are not intentional.
Co-authored-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
Co-authored-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
@Jamim thanks a lot for the review, got some good catches 💯 |
I realized this morning that this PR may change the behavior of of the previously Name: slack-sdk
Version: 3.26.0
Summary: The Slack API Platform SDK for Python
Home-page: https://github.com/slackapi/python-slack-sdk
Author: Slack Technologies, LLC
Author-email: opensource@slack.com
License: MIT
Location: /experiments/python_func_handler_mvp/env_3_11_2/lib/python3.11/site-packages
Requires:
Required-by: slack-bolt New Name: slack-sdk
Version: 3.26.0
Summary: The Slack API Platform SDK for Python
Home-page:
Author:
Author-email: "Slack Technologies, LLC" <opensource@slack.com>
License: MIT
Location: experiments/python_func_handler_mvp/env_3_11_2/lib/python3.11/site-packages
Requires:
Required-by: slack-bolt I'm not sure how developers may use this command but these changes could change their flow |
@WilliamBergamin Yeah, we should keep those metadata too. Can you make the changes for the compatibility? |
@seratch I've added the necessary changes to maintain the behavior of the here is the output Name: slack-sdk
Version: 3.26.0b1
Summary: The Slack API Platform SDK for Python
Home-page: https://github.com/slackapi/python-slack-sdk
Author: Slack Technologies, LLC
Author-email: opensource@slack.com
License: MIT
Location: /Users/env_3.11.2/lib/python3.11/site-packages
Requires:
Required-by: I've also deployed to https://test.pypi.org/project/slack-sdk I believe the deploy behavior is maintained |
Summary
This PR is an extension of #bolt-996 and aims to follow its spirit. It introduces changes that make the
pyproject.toml
file the default configuration file forpython-slack-sdk
The
setup.py
file is now used as support for "legacy" commands in this projectRequirements File Format pattern is used to import test dependencies. This creates a clear distinction between the project dependencies and the development dependencies.
Category
/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.