Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #382 Missing invite_requested event type #387

Merged
merged 3 commits into from
Feb 4, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Jan 30, 2020

Summary

This pull request fixes #382 by adding a new event type to base-events.ts
https://api.slack.com/events/invite_requested

@aoberoi @stevengill @shaydewael
If you're aware of some fields that need to be optional, please point them out. 🙏

Requirements (place an x in each [ ])

@seratch seratch added the enhancement M-T: A feature request for new functionality label Jan 30, 2020
@seratch seratch self-assigned this Jan 30, 2020
@seratch seratch mentioned this pull request Jan 30, 2020
3 tasks
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #387 into master will increase coverage by 0.54%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
+ Coverage   83.13%   83.68%   +0.54%     
==========================================
  Files           7        7              
  Lines         510      527      +17     
  Branches      148      151       +3     
==========================================
+ Hits          424      441      +17     
  Misses         57       57              
  Partials       29       29
Impacted Files Coverage Δ
src/middleware/process.ts 87.5% <100%> (ø) ⬆️
src/App.ts 87.7% <94.73%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c63cc7...d97d873. Read the comment docs.

date_created: number;
requester_ids: string[];
channel_ids: string[];
invite_type: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are three specific strings the invite_type value can be: restricted, ultra_restricted, or full_member. source: https://api.slack.com/admins/inviting#events

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aoberoi Good catch! I just modified it to be more specific. 👍

@seratch seratch merged commit c963e1d into slackapi:master Feb 4, 2020
@seratch seratch deleted the issue-382 branch February 4, 2020 02:48
@seratch
Copy link
Member Author

seratch commented Feb 4, 2020

This one is also the same to #359 (comment)

seratch added a commit that referenced this pull request Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing invite_requested event type
3 participants