Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #359 #387 to the @slack/bolt@next branch #393

Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 4, 2020

Summary

This pull request merges #359 #387 into the @slack/bolt@next brach that will be Bolt v2 soon. I've cafelly cherry-picked those commits but I would like to have others' review just in case.

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality semver:major labels Feb 4, 2020
@seratch seratch added this to the V2 milestone Feb 4, 2020
@seratch seratch self-assigned this Feb 4, 2020
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #393 into @slack/bolt@next will increase coverage by 0.53%.
The diff coverage is 95.45%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           @slack/bolt@next     #393      +/-   ##
====================================================
+ Coverage             83.56%   84.09%   +0.53%     
====================================================
  Files                     7        7              
  Lines                   505      522      +17     
  Branches                145      148       +3     
====================================================
+ Hits                    422      439      +17     
  Misses                   54       54              
  Partials                 29       29
Impacted Files Coverage Δ
src/middleware/process.ts 87.5% <100%> (ø) ⬆️
src/App.ts 88.48% <95%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5881471...2901492. Read the comment docs.

@juank11memphis
Copy link

Hello!!

Hey is there a way to point the npm package to this "next" version?
I am working on a project that needs the "invite_requested" event so I was wondering if I can make use of that before waiting for the official v2 of the framework.

Thanks a lot in advance :)

@stevengill
Copy link
Member

@juank11memphis This is the way I do it:

git clone https://github.com/slackapi/bolt.git
cd bolt
git fetch
git checkout next
npm install
npm build 
// make a global symlink for bolt
npm link 

From there, navigate to your apps directory (Where you want to use this next version of bolt). Run the following command.

npm link bolt

This should make it so you are using your globally linked bolt instead of the one in your node_modules directory. You can verify by navigating to your node_modules -> @slack directory in your app and typing ls -al. It should show the bolt dependency using a path.

Let me know if that works for you.

@stevengill
Copy link
Member

@juank11memphis if invite_requested is what you need, bolt@1.6.0 just got released to npm and it includes it.

@seratch seratch merged commit cac1fb6 into slackapi:@slack/bolt@next Feb 5, 2020
@seratch seratch deleted the @slack/bolt@next-seratch-prs branch February 5, 2020 02:05
@juank11memphis
Copy link

Hi @stevengill

Thanks a lot, yeah I noticed that this morning, that's awesome news!

Thanks also for the npm link advice, now I know how to do this if in the future I need stuff from @next version :)

barlock added a commit to barlock/bolt that referenced this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants