Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose middleware resolve conflicts with #393 #2

Conversation

seratch
Copy link

@seratch seratch commented Feb 5, 2020

Summary

This pull request fixes git conflicts with slackapi#393 .

Two test suites I've added detected an issue where all `app.event` listeners are not called in this branch. I'm still thinking of a proper way to fix it. Any thoughts?
  91 passing (8s)
  2 failing

  1) App
       event processing
         middleware and listener arguments
           logger
             should be available in middleware/listener args:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.it (src/App.spec.ts:694:18)

  2) App
       event processing
         middleware and listener arguments
           client
             should be available in middleware/listener args:
     TypeError: Cannot read property 'token' of undefined
      at Context.it (src/App.spec.ts:760:35)

@seratch seratch mentioned this pull request Feb 5, 2020
2 tasks
@seratch
Copy link
Author

seratch commented Feb 5, 2020

The test failures were just my bad... 🙏 I've fixed them.

@barlock barlock merged commit 0c300ee into barlock:compose-middleware Feb 6, 2020
@barlock
Copy link
Owner

barlock commented Feb 6, 2020

Thanks for doing the merge for me!

@seratch seratch deleted the compose-middleware-resolve-conflicts branch June 20, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants