Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for v2 based on feedback #439

Merged
merged 3 commits into from
Mar 25, 2020

Conversation

stevengill
Copy link
Member

Summary

Updates based on comments on #380 & #381

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #439 into @slack/bolt@next will increase coverage by 0.61%.
The diff coverage is 29.41%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           @slack/bolt@next     #439      +/-   ##
====================================================
+ Coverage              85.1%   85.71%   +0.61%     
====================================================
  Files                     7        7              
  Lines                   537      532       -5     
  Branches                158      156       -2     
====================================================
- Hits                    457      456       -1     
+ Misses                   52       48       -4     
  Partials                 28       28
Impacted Files Coverage Δ
src/errors.ts 100% <100%> (+6.06%) ⬆️
src/ExpressReceiver.ts 72.44% <20%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8abaf9...cf56506. Read the comment docs.

@seratch
Copy link
Member

seratch commented Mar 25, 2020

@stevengill can you cherry-pick this commit for corresponding changes to Japanese docs? seratch@37bfd07

src/App.spec.ts Outdated Show resolved Hide resolved
@stevengill stevengill merged commit 17d23d1 into slackapi:@slack/bolt@next Mar 25, 2020
@stevengill stevengill deleted the updates branch March 25, 2020 21:53
@stevengill stevengill restored the updates branch March 25, 2020 21:53
@stevengill stevengill deleted the updates branch March 25, 2020 21:53
@aoberoi aoberoi mentioned this pull request Mar 27, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants