Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make App.handleError() private (v2) #446

Merged

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Mar 27, 2020

Summary

The App.handleError() method used to be used by the ExpressReceiver before #439. Receivers no longer need this method because they are strictly downstream of the event handling in an app. Therefore it makes sense to turn this into a private method.

Depends on #440 (integration tests will fail without it)

Requirements (place an x in each [ ])

@aoberoi aoberoi added this to the v2.0 milestone Mar 27, 2020
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #446 into @slack/bolt@next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           @slack/bolt@next     #446   +/-   ##
=================================================
  Coverage             85.71%   85.71%           
=================================================
  Files                     7        7           
  Lines                   532      532           
  Branches                156      156           
=================================================
  Hits                    456      456           
  Misses                   48       48           
  Partials                 28       28
Impacted Files Coverage Δ
src/App.ts 88.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb48ee...d4c9fae. Read the comment docs.

@stevengill stevengill merged commit 56f0416 into slackapi:@slack/bolt@next Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants