Bradh workflow extension support #546
Conversation
Codecov Report
@@ Coverage Diff @@
## feat-workflow-steps #546 +/- ##
====================================================
Coverage 83.13% 83.13%
====================================================
Files 7 7
Lines 593 593
Branches 184 184
====================================================
Hits 493 493
Misses 68 68
Partials 32 32
Continue to review full report at Codecov.
|
| trigger_id: string; | ||
| user: { | ||
| id: string; | ||
| name: string; |
There was a problem hiding this comment.
user object in action payload has a key of username rather than name
| action_ts: string; // undocumented | ||
| workflow_step: { | ||
| workflow_id: string; | ||
| step_id: string; |
There was a problem hiding this comment.
workflow_step also has keys for inputs and outputs in either case (add vs. edit)
src/types/events/base-events.ts
Outdated
| callback_id: string; | ||
| workflow_step: { | ||
| workflow_step_execute_id: string; | ||
| workflow_id: string, |
There was a problem hiding this comment.
A few commas here instead of semi-colons
|
|
| trigger_id: string; | ||
| user: { | ||
| id: string; | ||
| username: string; |
There was a problem hiding this comment.
This was changed from name to username based on the payloads
There was a problem hiding this comment.
Thanks for catching and fixes all of those 😄
Summary
This PR adds support for a new feature entering open beta called Workflow Steps from Apps. It allows Slack apps to provide custom steps for Slack Workflows. This new feature requires the following updates to Bolt, encompassed in these changes:
workflow_step_editactionworkflow_step_executeeventsayfunction from theworkflow_step_edithandlergetTypeAndConversation()to allowworkflow_step_editaction to fall into the action handling logicRequirements (place an
xin each[ ])