-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bradh workflow extension support #546
Merged
stevengill
merged 5 commits into
slackapi:feat-workflow-steps
from
selfcontained:bradh-workflow-extension-support
Jul 20, 2020
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
77aa983
add support for workflow_step actions
selfcontained bd970d4
add workflow_step_started event type
selfcontained 1d192f8
updating event and action names/props for first round of feedback cha…
selfcontained 47bd063
updating props to account for some changes
selfcontained 22bcdfb
Apply suggestions from code review
misscoded File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/** | ||
* A Slack workflow step action wrapped in the standard metadata. | ||
* | ||
* This describes the entire JSON-encoded body of a request from Slack workflow step actions. | ||
*/ | ||
export interface WorkflowStepEdit { | ||
type: 'workflow_step_edit'; | ||
callback_id: string; | ||
trigger_id: string; | ||
user: { | ||
id: string; | ||
username: string; | ||
team_id?: string; // undocumented | ||
}; | ||
team: { | ||
id: string; | ||
domain: string; | ||
enterprise_id?: string; // undocumented | ||
enterprise_name?: string; // undocumented | ||
}; | ||
channel?: { | ||
id?: string; | ||
name?: string; | ||
}; | ||
token: string; | ||
action_ts: string; // undocumented | ||
workflow_step: { | ||
workflow_id: string; | ||
step_id: string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
misscoded marked this conversation as resolved.
Show resolved
Hide resolved
|
||
inputs: object; | ||
outputs: []; | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed from
name
tousername
based on the payloadsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching and fixes all of those 😄