adding more detail to workflow step action/event types #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orkflow_step object on view submission
selfcontained
force-pushed
the
bradh-update-workflow-step-types
branch
from
de374ba
to
ffac7e9
Compare
Codecov Report
@@ Coverage Diff @@
## feat-workflow-steps #578 +/- ##
====================================================
Coverage 83.13% 83.13%
====================================================
Files 7 7
Lines 593 593
Branches 184 184
====================================================
Hits 493 493
Misses 68 68
Partials 32 32 Continue to review full report at Codecov.
|
stevengill
approved these changes
Aug 13, 2020
misscoded
approved these changes
Aug 13, 2020
| @@ -44,6 +44,11 @@ export interface ViewSubmitAction { | |||
| view: ViewOutput; | |||
| api_app_id: string; | |||
| token: string; | |||
| workflow_step?: { | |||
There was a problem hiding this comment.
These changes to ViewSubmitAction and ViewClosedAction will likely be removed in an upcoming release, but if it's helpful to merge and release these in the meantime, happy to do so!
|
It would help with some type dependent work we’re doing on an app currently
if we had these for the interim.
…On Thu, Aug 13, 2020 at 4:28 PM Alissa Renz ***@***.***> wrote:
***@***.**** approved this pull request.
One note on the changes to the View interfaces, but as long as everyone is
on the same page with that, this LGTM!
------------------------------
In src/types/view/index.ts
<#578 (comment)>:
> @@ -44,6 +44,11 @@ export interface ViewSubmitAction {
view: ViewOutput;
api_app_id: string;
token: string;
+ workflow_step?: {
These changes to ViewSubmitAction and ViewClosedAction will likely be
removed in an upcoming release, but if it's helpful to merge and release
these in the meantime, happy to do so!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#578 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACZVK2HRDZHUIZQIUOJEYLSARSIVANCNFSM4P62CXEQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR flushes out some of the types associated with the workflow_step feature a bit more. There is also an optional
workflow_stepobject on view submit/close events now too that this accounts for.Requirements (place an
xin each[ ])