Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding more detail to workflow step action/event types #578

Merged
merged 1 commit into from
Aug 17, 2020
Merged

adding more detail to workflow step action/event types #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/types/actions/workflow-step-edit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,17 @@ export interface WorkflowStepEdit {
workflow_step: {
workflow_id: string;
step_id: string;
inputs: object;
outputs: [];
inputs: {
[key: string]: {
value: any;
},
};
outputs: {
name: string;
type: string;
label: string;
}[];
step_name?: string;
step_image_url?: string;
};
}
6 changes: 5 additions & 1 deletion src/types/events/base-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,11 @@ export interface WorkflowStepExecuteEvent extends StringIndexed {
workflow_id: string;
workflow_instance_id: string;
step_id: string;
inputs: object;
inputs: {
[key: string]: {
value: any;
},
};
outputs: {
name: string;
type: string;
Expand Down
10 changes: 10 additions & 0 deletions src/types/view/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ export interface ViewSubmitAction {
view: ViewOutput;
api_app_id: string;
token: string;
workflow_step?: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes to ViewSubmitAction and ViewClosedAction will likely be removed in an upcoming release, but if it's helpful to merge and release these in the meantime, happy to do so!

workflow_step_edit_id: string;
workflow_id: string;
step_id: string;
};
}

/**
Expand All @@ -68,6 +73,11 @@ export interface ViewClosedAction {
api_app_id: string;
token: string;
is_cleared: boolean;
workflow_step?: {
workflow_step_edit_id: string;
workflow_id: string;
step_id: string;
};
}

export interface ViewOutput {
Expand Down