Adding support and check for the event subtypes #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaspard Petit <gaspard.petit@eidosmontreal.com>
|
|
seratch
requested changes
May 8, 2020
slack-api-model/src/main/java/com/slack/api/model/event/Event.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gaspard Petit <gaspard.petit@eidosmontreal.com>
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
============================================
- Coverage 83.99% 83.64% -0.36%
- Complexity 2385 2386 +1
============================================
Files 250 250
Lines 6406 6438 +32
Branches 579 586 +7
============================================
+ Hits 5381 5385 +4
- Misses 667 694 +27
- Partials 358 359 +1
Continue to review full report at Codecov.
|
seratch
added a commit
that referenced
this pull request
May 12, 2020
|
Thanks for your contribution 🙇♂️ I've verified your change works and merged into the |
gaspardpetit
deleted the
java_slack_sdk_support_subtypes_when_deserializing
branch
|
Thanks for adding a test and accepting my PR! I will do my best to include one next time I contribute. |
seratch
added a commit
that referenced
this pull request
May 28, 2020
* [slack-api-model] Add missing fields in objects (confirm.style in blocks, user.is_invited_user: boolean, message.hidden, Slack post related fields in file objects) - thanks @seratch * [slack-api-client etc] #466 #462 Calls API support - thanks @seratch * [slack-api-client] #475 #474 Make redirect_uri for oauth.access / oauth.v2.access optional - thanks @natevaughan @seratch * [slack-api-client] #476 Bump dependencies (okhttp, micronaut, tyrus-standalone-client) - thanks @seratch * [slack-api-client] #459 Adding ping message and pong event to RTM client - thanks @gaspardpetit * [slack-api-client] #451 Add support and check for the event subtypes in RTM client - thanks @gaspardpetit * [bolt] #455 Improve OAuth flow module to consider the cases where team is missing in oauth.v2.access responses - thanks @seratch * [bolt] #476 Bump dependencies (aws-java-sdk-s3) - thanks @seratch
emanguy
pushed a commit
to emanguy/java-slack-sdk
that referenced
this pull request
Jun 22, 2020
emanguy
pushed a commit
to emanguy/java-slack-sdk
that referenced
this pull request
Jun 22, 2020
* [slack-api-model] Add missing fields in objects (confirm.style in blocks, user.is_invited_user: boolean, message.hidden, Slack post related fields in file objects) - thanks @seratch * [slack-api-client etc] slackapi#466 slackapi#462 Calls API support - thanks @seratch * [slack-api-client] slackapi#475 slackapi#474 Make redirect_uri for oauth.access / oauth.v2.access optional - thanks @natevaughan @seratch * [slack-api-client] slackapi#476 Bump dependencies (okhttp, micronaut, tyrus-standalone-client) - thanks @seratch * [slack-api-client] slackapi#459 Adding ping message and pong event to RTM client - thanks @gaspardpetit * [slack-api-client] slackapi#451 Add support and check for the event subtypes in RTM client - thanks @gaspardpetit * [bolt] slackapi#455 Improve OAuth flow module to consider the cases where team is missing in oauth.v2.access responses - thanks @seratch * [bolt] slackapi#476 Bump dependencies (aws-java-sdk-s3) - thanks @seratch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaspard Petit gaspard.petit@eidosmontreal.com
Summary
Right now the RTM client does not consider the subtype when deserializing messages and dispatching them. This results in class conversion exceptions when multiple handlers are registered for different events of the same types, ex. MessageEvent and MessageChangedEvents. Both receive the notification possibly with the wrong object type.
Requirements (place an
xin each[ ])