Fix #474 by making redirect_uri optional #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
bug
stevengill
approved these changes
May 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
============================================
- Coverage 83.69% 83.64% -0.06%
- Complexity 2415 2416 +1
============================================
Files 251 251
Lines 6503 6505 +2
Branches 592 594 +2
============================================
- Hits 5443 5441 -2
- Misses 695 699 +4
Partials 365 365
Continue to review full report at Codecov.
|
seratch
added a commit
that referenced
this pull request
May 28, 2020
* [slack-api-model] Add missing fields in objects (confirm.style in blocks, user.is_invited_user: boolean, message.hidden, Slack post related fields in file objects) - thanks @seratch * [slack-api-client etc] #466 #462 Calls API support - thanks @seratch * [slack-api-client] #475 #474 Make redirect_uri for oauth.access / oauth.v2.access optional - thanks @natevaughan @seratch * [slack-api-client] #476 Bump dependencies (okhttp, micronaut, tyrus-standalone-client) - thanks @seratch * [slack-api-client] #459 Adding ping message and pong event to RTM client - thanks @gaspardpetit * [slack-api-client] #451 Add support and check for the event subtypes in RTM client - thanks @gaspardpetit * [bolt] #455 Improve OAuth flow module to consider the cases where team is missing in oauth.v2.access responses - thanks @seratch * [bolt] #476 Bump dependencies (aws-java-sdk-s3) - thanks @seratch
emanguy
pushed a commit
to emanguy/java-slack-sdk
that referenced
this pull request
Jun 22, 2020
* [slack-api-model] Add missing fields in objects (confirm.style in blocks, user.is_invited_user: boolean, message.hidden, Slack post related fields in file objects) - thanks @seratch * [slack-api-client etc] slackapi#466 slackapi#462 Calls API support - thanks @seratch * [slack-api-client] slackapi#475 slackapi#474 Make redirect_uri for oauth.access / oauth.v2.access optional - thanks @natevaughan @seratch * [slack-api-client] slackapi#476 Bump dependencies (okhttp, micronaut, tyrus-standalone-client) - thanks @seratch * [slack-api-client] slackapi#459 Adding ping message and pong event to RTM client - thanks @gaspardpetit * [slack-api-client] slackapi#451 Add support and check for the event subtypes in RTM client - thanks @gaspardpetit * [bolt] slackapi#455 Improve OAuth flow module to consider the cases where team is missing in oauth.v2.access responses - thanks @seratch * [bolt] slackapi#476 Bump dependencies (aws-java-sdk-s3) - thanks @seratch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #474 by making
redirect_uriparameter optional foroauth.accessandoauth.v2.accessAPI method calls.Requirements (place an
xin each[ ])