socket-mode(build): use a minimum version of web-api@7.3.4 #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeg
added
semver:patch
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 34 34
Lines 7648 7648
Branches 374 374
=======================================
Hits 6872 6872
Misses 764 764
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
filmaj
requested changes
Aug 15, 2024
Co-authored-by: Fil Maj <maj.fil@gmail.com>
filmaj
approved these changes
Aug 15, 2024
zimeg
changed the title
|
@filmaj Thanks tons for the correction! Would it make sense to apply similar changes to other packages using the unspecified Edit: Release trains are exciting rides if so! 🚂 💨 |
|
@zimeg yeah, if the goal is to force everyone onto a secure version of axios, we unfortunately must do so. |
|
@filmaj Urgh for the noise it causes but I do believe it's the right call 🔐 I shall attend to this over these next hours 🫡 |
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the latest version of
@slack/web-api@7to support the most recent releases without worries of bumping the minor and patch numbers or confusion with past numbers.Notes
Noticed this pattern in a casual inspection of the
@slack/oauthpackages and am thinking it's good to use here too!Had to dig a bit to confirm this, but running
npm updatein projects using@slack/socket-modeshould bump@slack/web-apito the latest7.b.cor whatever's specified otherwise. Docs on how dependencies update are here 📚Requirements