Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtm-api(build): use a minimum version of @slack/web-api@7.3.4 #1887

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Aug 16, 2024

Summary

This PR sets the minimum version of @slack/web-api to 7.3.4 to address CVE-2024-39338. Follows #1878.

Requirements

@zimeg zimeg added semver:patch pkg:rtm-api applies to `@slack/rtm-api` release labels Aug 16, 2024
@zimeg zimeg added this to the rtm-api@7.0.1 milestone Aug 16, 2024
@zimeg zimeg self-assigned this Aug 16, 2024
@zimeg zimeg merged commit 495a8fd into main Aug 16, 2024
28 checks passed
@zimeg zimeg deleted the rtm-api-chore-bump-web-api-7.3.4 branch August 16, 2024 00:36
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (7910bc9) to head (82812bc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1887   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          34       34           
  Lines        7648     7648           
  Branches      374      374           
=======================================
  Hits         6872     6872           
  Misses        764      764           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 94.94% <ø> (ø)
cli-test 94.77% <ø> (ø)
oauth 76.53% <ø> (ø)
socket-mode 59.59% <ø> (ø)
web-api 96.57% <ø> (ø)
webhook 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:rtm-api applies to `@slack/rtm-api` release semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant