Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1462 websocket_client-based SocketModeClient does not reconnect after a DNS outage #1466

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 28, 2024

Summary

This pull request resolves #1462

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x socket-mode labels Feb 28, 2024
@seratch seratch added this to the 3.27.1 milestone Feb 28, 2024
@seratch
Copy link
Member Author

seratch commented Feb 28, 2024

Similar changes may be necessary for other implementation but my current guess is that this issue can be websocket_client package specific. When we receive similar feedback for other implementations in the future, we can add the same changes after doing enough tests (especially for the built-in one, which has a large number of users).

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (fe45e0b) to head (88ebd87).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
- Coverage   85.36%   85.33%   -0.03%     
==========================================
  Files         111      111              
  Lines       12289    12291       +2     
==========================================
- Hits        10490    10489       -1     
- Misses       1799     1802       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit cd78ab4 into slackapi:main Feb 28, 2024
12 checks passed
@seratch seratch deleted the issue-1462 branch February 28, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented socket-mode Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

websocket_client-based SocketModeClient does not reconnect after a DNS outage
1 participant