Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1462 websocket_client-based SocketModeClient does not reconnect after a DNS outage #1466

Merged
merged 1 commit into from
Feb 28, 2024
+3 −0
Merged

Fix #1462 websocket_client-based SocketModeClient does not reconnect after a DNS outage #1466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions slack_sdk/socket_mode/websocket_client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,9 @@ def _run_current_session(self):
self.logger.info("Stopped receiving messages from a connection")
except Exception as e:
self.logger.exception(f"Failed to start or stop the current session: {e}")
# To let the monitoring job detect the connection issue, closing this session
if self.current_session is not None:
self.current_session.close()

def _monitor_current_session(self):
if self.current_app_monitor_started:
Expand Down
Loading