Skip to content

Conversation

@vegeris
Copy link
Contributor

@vegeris vegeris commented Nov 18, 2025

Summary

Missed these updates for entity.presentDetails in the earlier PR:

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.68%. Comparing base (4277ed8) to head (7820afe).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
slack_sdk/web/async_client.py 50.00% 1 Missing ⚠️
slack_sdk/web/client.py 50.00% 1 Missing ⚠️
slack_sdk/web/legacy_client.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1793      +/-   ##
==========================================
- Coverage   83.70%   83.68%   -0.02%     
==========================================
  Files         115      115              
  Lines       12902    12905       +3     
==========================================
  Hits        10800    10800              
- Misses       2102     2105       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vegeris vegeris marked this pull request as ready for review November 18, 2025 15:37
@vegeris vegeris requested a review from a team as a code owner November 18, 2025 15:37
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@vegeris vegeris added enhancement M-T: A feature request for new functionality semver:minor labels Nov 18, 2025
@vegeris vegeris added this to the 3.39.0 milestone Nov 18, 2025
@vegeris vegeris merged commit e802f17 into main Nov 18, 2025
23 of 25 checks passed
@vegeris vegeris deleted the feat-work-objects-update branch November 18, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants