Skip to content

feat: update work objects support (entity.presentDetails) #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

feat: update work objects support (entity.presentDetails) #1793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d398d3
update entity.presentDetails impl
vegeris Nov 18, 2025
7820afe
format
vegeris Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions slack_sdk/web/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

from ..models.attachments import Attachment
from ..models.blocks import Block
from ..models.metadata import Metadata, EventAndEntityMetadata
from ..models.metadata import Metadata, EntityMetadata, EventAndEntityMetadata
from .async_base_client import AsyncBaseClient, AsyncSlackResponse
from .internal_utils import (
_parse_web_class_objects,
Expand Down Expand Up @@ -3650,10 +3650,10 @@ async def emoji_list(
async def entity_presentDetails(
self,
trigger_id: str,
metadata: Optional[dict] = None,
metadata: Optional[Union[Dict, EntityMetadata]] = None,
user_auth_required: Optional[bool] = None,
user_auth_url: Optional[str] = None,
error: Optional[Dict[str, str]] = None,
error: Optional[Dict[str, Any]] = None,
**kwargs,
) -> AsyncSlackResponse:
"""Provides entity details for the flexpane.
Expand All @@ -3668,6 +3668,7 @@ async def entity_presentDetails(
kwargs.update({"user_auth_url": user_auth_url})
if error is not None:
kwargs.update({"error": error})
_parse_web_class_objects(kwargs)
return await self.api_call("entity.presentDetails", json=kwargs)

async def files_comments_delete(
Expand Down
7 changes: 4 additions & 3 deletions slack_sdk/web/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

from ..models.attachments import Attachment
from ..models.blocks import Block
from ..models.metadata import Metadata, EventAndEntityMetadata
from ..models.metadata import Metadata, EntityMetadata, EventAndEntityMetadata
from .base_client import BaseClient, SlackResponse
from .internal_utils import (
_parse_web_class_objects,
Expand Down Expand Up @@ -3640,10 +3640,10 @@ def emoji_list(
def entity_presentDetails(
self,
trigger_id: str,
metadata: Optional[dict] = None,
metadata: Optional[Union[Dict, EntityMetadata]] = None,
user_auth_required: Optional[bool] = None,
user_auth_url: Optional[str] = None,
error: Optional[Dict[str, str]] = None,
error: Optional[Dict[str, Any]] = None,
**kwargs,
) -> SlackResponse:
"""Provides entity details for the flexpane.
Expand All @@ -3658,6 +3658,7 @@ def entity_presentDetails(
kwargs.update({"user_auth_url": user_auth_url})
if error is not None:
kwargs.update({"error": error})
_parse_web_class_objects(kwargs)
return self.api_call("entity.presentDetails", json=kwargs)

def files_comments_delete(
Expand Down
6 changes: 5 additions & 1 deletion slack_sdk/web/internal_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,11 @@ def to_dict(obj: Union[Dict, Block, Attachment, Metadata, EventAndEntityMetadata
kwargs.update({"attachments": dict_attachments})

metadata = kwargs.get("metadata", None)
if metadata is not None and (isinstance(metadata, Metadata) or isinstance(metadata, EventAndEntityMetadata)):
if metadata is not None and (
isinstance(metadata, Metadata)
or isinstance(metadata, EntityMetadata)
or isinstance(metadata, EventAndEntityMetadata)
):
kwargs.update({"metadata": to_dict(metadata)})


Expand Down
7 changes: 4 additions & 3 deletions slack_sdk/web/legacy_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

from ..models.attachments import Attachment
from ..models.blocks import Block
from ..models.metadata import Metadata, EventAndEntityMetadata
from ..models.metadata import Metadata, EntityMetadata, EventAndEntityMetadata
from .legacy_base_client import LegacyBaseClient, SlackResponse
from .internal_utils import (
_parse_web_class_objects,
Expand Down Expand Up @@ -3588,10 +3588,10 @@ def emoji_list(
def entity_presentDetails(
self,
trigger_id: str,
metadata: Optional[dict] = None,
metadata: Optional[Union[Dict, EntityMetadata]] = None,
user_auth_required: Optional[bool] = None,
user_auth_url: Optional[str] = None,
error: Optional[Dict[str, str]] = None,
error: Optional[Dict[str, Any]] = None,
**kwargs,
) -> Union[Future, SlackResponse]:
"""Provides entity details for the flexpane.
Expand All @@ -3606,6 +3606,7 @@ def entity_presentDetails(
kwargs.update({"user_auth_url": user_auth_url})
if error is not None:
kwargs.update({"error": error})
_parse_web_class_objects(kwargs)
return self.api_call("entity.presentDetails", json=kwargs)

def files_comments_delete(
Expand Down