-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module
to package.json for rollup/webpack
#281
Conversation
I rebased onto master |
module
to package.json for rollup/webpack
Hmm actually, after clicking through those PRs, I found this comment at #243 (comment):
I guess we can see if this is actually a problem, once this change is published. |
Ah well, if there are usages of non-standard syntax or features not in node 8, then we’d just remove this. The only reason I proposed it was to prevent bundlers from importing (yet another version of/potentially conflicting) babel runtime. As well as potentially making the bundled size even smaller. The real and final solution will be to reconfigure babel not to use the runtime. The Rollup change does this. (The runtime is meant to be used by applications to minimize babel helper code duplication at the app level... libraries are discouraged from using it) |
I've updated my other pr to produce a esm module so that the src goes through babel. |
All webpack users? or commonjs-webpack users? |
for all webpack users - we are not using commonjs but one of our dependencies does |
Ah |
This will allow users to consume the original esm modern code. This would make #275 a minor non-blocking issue. :)