-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rollup to simplify build/babel/lint #282
Conversation
I just noticed #243 ... this maybe a cleaner approach. I made this produce the cjs/umd instead of producing an es module... This makes the original |
since the umd is nearly ident to the cjs, I could just make the |
I've rebased onto your master. |
I've updated this to incorporate yesterdays comments from #243 ... I've also fully commented the rollup config. |
incorporate comments: - Don't publish src. - Rollup produces both umd and esm outputs.
Squashed & rebased. Hope this is found useful :) |
This sounds good, but I'm not actively supporting XRegExp these days and I'm not very familiar with the details of cjs/umd/esm, rollup, babel, etc., so I'd appreciate insight from @josephfrazier or others. |
This should probably be inverted to produce a commonjs & umd build instead of esm & umd... let modern node have the raw sources. |
supersedes #243, #275.
includes #281
This updates all devDependencies to latest (as of now) and removes the need for any babel-runtime dependencies (rollup bakes them in & dedups them for us) This also moves
zuul
to a npx (on demand) script (since it prints many deprecation warnings atm) The only deprecation warning on install is core-js@2 (which comes from a babel-transform plugin)Thoughts?
With this change, rollup produces both cjs & umd bundles.
npm test
passes.