Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

donotdisturb: Add wayland fullscreen detection #427

Merged
merged 2 commits into from
Apr 18, 2021

Conversation

cyrinux
Copy link
Contributor

@cyrinux cyrinux commented Feb 24, 2021

This will works with the next sway release or the current sway master branch.

@cyrinux cyrinux force-pushed the add_sway_fullscreen_detection branch 3 times, most recently from c5847e0 to 836faa2 Compare February 24, 2021 15:41
@cyrinux cyrinux changed the title Add wayland fullscreen detection donotdisturb: Add wayland fullscreen detection Feb 24, 2021
Will work with the next sway release or current master branch.
@cyrinux cyrinux force-pushed the add_sway_fullscreen_detection branch from 836faa2 to 0e3c0f8 Compare February 24, 2021 15:59
@slgobinath
Copy link
Owner

Hi, thank you for the PR. I will test it on a wayland VM and merge the PR at my earliest.

@cyrinux
Copy link
Contributor Author

cyrinux commented Apr 14, 2021

Hi @slgobinath, any chance you give an eye to this PR?
Sway was updated and it should be ok now 😃

@slgobinath
Copy link
Owner

slgobinath commented Apr 16, 2021

Hi @cyrinux, I'm extremely sorry for the late response. I just setup the Fedora VM and noticed that the wlrctl wasn't there. I am not familiar with Wayland. Is wlrctl suppose to work with all Wayland window managers?

We may also need a dependency_checker.py as I have for the smartpause plugin to check wlrctl in Wayland and xprop in XOrg. After adding the dependency_checker, the shell command array in the config file must be empty.

@cyrinux
Copy link
Contributor Author

cyrinux commented Apr 16, 2021

Hi @slgobinath,
No problem 😸 , I will add the dependency_check.
About https://git.sr.ht/~brocellous/wlrctl I understand it can manage all WM based on wlroots.
I about don't recently play with Fedora but I can' find this user repository with the toy inside http://copr.fedorainfracloud.org/coprs/alebastr/sway-extras/
Here, I use Archlinux, maybe if you want a quick test, it will be easy for you with a Manjaro with sway https://github.com/Manjaro-Sway/manjaro-sway and then install the package wlrctl-git from the AUR repository ?

@maximbaz
Copy link

maximbaz commented Apr 16, 2021

I can confirm that it is working well for me too on the latest sway 👍

To clarify for you @slgobinath, contrary to Xorg there is no single way like xprop to find a full screen app on Wayland, so we have to interact with specific WM to get this information. wlrctl is nice because it works on wlroots level (a library used to build several different WMs), so it supports not a single WM, but a range of them (e.g. sway, wayfire). But still it's not entire Wayland, so it's definitely possible that in the future you will receive more PRs extending this support to even more WMs.

Hope that clarifies some things?

@slgobinath
Copy link
Owner

slgobinath commented Apr 18, 2021

@maximbaz thank you for the clarification. I am not familiar with the Wayland. Since you have confirmed it, I am merging this PR without testing by myself.

@cyrinux thanks again for your contribution and please accept my apologies for keeping this PR this long.

@slgobinath slgobinath merged commit 6e07de7 into slgobinath:master Apr 18, 2021
@cyrinux
Copy link
Contributor Author

cyrinux commented Apr 18, 2021

Happy to get this merged. Thanks @slgobinath and @maximbaz.
Don't worry, I'm happy to contribute 😃 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants